Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the output for better usability #196

Open
angiehjort opened this issue Aug 9, 2016 · 1 comment
Open

Improve the output for better usability #196

angiehjort opened this issue Aug 9, 2016 · 1 comment

Comments

@angiehjort
Copy link
Member

angiehjort commented Aug 9, 2016

When everything is done print the result: valid or invalid? I just came in to read that one word

Format JSON output

Remove empty object in the end

currently

[
{"id":"NON_DDF_FOLDER","type":"This folder is not DDF","path":"/Volumes/angie-data/_GIT/ddf--gapminder--systema_globalis/etl","tags":["WARNING","FILE_SYSTEM"]},

{"id":"INCORRECT_JSON_FIELD","type":"Incorrect JSON field","path":"/Volumes/angie-data/_GIT/ddf--gapminder--systema_globalis/ddf--entities--geo--country.csv","data":{"column":"arb5","line":55,"value":"Congo [DRC]"},"tags":["WARNING"]},

{}]

suggested

WARNING: This folder is not DDF /etl
WARNING: Incorrect JSON field (55:arb5): "Congo [DRC]" in /ddf--entities--geo--country.csv
Validation complete. Your DDF is valid!
@angiehjort
Copy link
Member Author

angiehjort commented Apr 15, 2018

The above is largely solved with extra file/gapminder offline implementation

Further improvement: when creating datapackage please output the result to the console "Datapackage creates successfully" rather than creating a log file for that (i need to do it often and remove the file every time!)

create a log file only when there are issues


when validation is complete with errors or warnings print the total error and warning count

it is useful because i expect to have the 2 warnings in the file but too lazy to open it and check if there aren't more of them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant