Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use grid layout instead of flexbox for infobox #22

Open
smallketchup82 opened this issue Dec 11, 2024 · 0 comments
Open

Use grid layout instead of flexbox for infobox #22

smallketchup82 opened this issue Dec 11, 2024 · 0 comments
Labels
site:styling Concerns styling status:needs discussion Needs more discussion before making any calls

Comments

@smallketchup82
Copy link
Member

Currently we use a flexbox layout for infoboxes and manage rows and columns ourselves. This is honestly bad practice since we can let css do all of that for us.

We can use a grid layout instead. Define 2 columns and seperate every individual grid by the headers. Now, every property is aligned in rows of 2. If the total number of parameters is odd, one whole row is used by one property.

This should roughly match mediawiki and allow us to slam more information in the infobox, making it less tall, giving more room for the page's content.

@smallketchup82 smallketchup82 added status:needs discussion Needs more discussion before making any calls site:styling Concerns styling labels Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site:styling Concerns styling status:needs discussion Needs more discussion before making any calls
Projects
None yet
Development

No branches or pull requests

1 participant