Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Edit Preset" page can be opened before creating a preset #2

Open
lhvy opened this issue Jun 20, 2021 · 3 comments
Open

"Edit Preset" page can be opened before creating a preset #2

lhvy opened this issue Jun 20, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@lhvy
Copy link

lhvy commented Jun 20, 2021

Describe the bug
No default preset is created and the preferences of this tweak allows for opening the edit preset page and then redirection back to the main settings for the tweak without telling the user why this is happening. If the user opens edit preset page by 3D touching the page, they will not get redirected back to the main page and can edit the preset settings but they will not be saved on exiting the page.

To Reproduce
Steps to reproduce the behaviour:

  1. Clean install the tweak or delete all preferences and presets
  2. Click on "Edit Presets" in the tweak settings page

Expected behavior
A default preset for the user to edit exists upon installing the tweak or a warning is issued that no preset exists and the user should create one when trying to use the edit presets page.

Smartphone (please complete the following information):

  • Device: iPhone XS
  • OS: iOS 14.3
  • Version: 1.0
@lhvy lhvy added the bug Something isn't working label Jun 20, 2021
@Galactic-Dev
Copy link
Owner

This is the default behavior, but I can change it to be more descriptive/helpful.

@lhvy
Copy link
Author

lhvy commented Jun 20, 2021

Thanks! Making it more clear should help, I wasn't sure why the page was closing itself as soon as I clicked it and assumed something was going wrong until I realised I needed to make a new preset first.

@Galactic-Dev
Copy link
Owner

Thanks! Making it more clear should help, I wasn't sure why the page was closing itself as soon as I clicked it and assumed something was going wrong until I realised I needed to make a new preset first.

Yeah I'll definitely add an alert in the next version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants