Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanilla chests lighting flickering after JABBA code change #16410

Closed
2 of 3 tasks
leafi opened this issue May 29, 2024 · 3 comments · Fixed by GTNewHorizons/Jabba#33
Closed
2 of 3 tasks

Vanilla chests lighting flickering after JABBA code change #16410

leafi opened this issue May 29, 2024 · 3 comments · Fixed by GTNewHorizons/Jabba#33
Labels
Bug: Minor Mod: Angelica Transfer this issue to the Angelica repo Mod: JABBA

Comments

@leafi
Copy link

leafi commented May 29, 2024

Your GTNH Discord Username

No response

Your Pack Version

2.6.1, Nightly 486

Your Server

SP

Java Version

Java 21

Type of Server

None

Your Expectation

In 2.6.0, I could look around my base without lighting flickering on vanilla chests.

In 2.6.1 and in Nightly 486, there are lighting problems. Substituting an old JABBA jar restores expected behaviour.

The Reality

Nightly 486, all mods left as-is, just my 2.6.0 world transplanted:

gtnh-base-chest-nightly486-jabba142-bad-fixvid.mp4

I bisected the mods/ folder between 2.6.0 and 2.6.1, and determined JABBA changes were the cause. (Makes sense - I use the barrels.)

Nightly 486, but with JABBA reverted from 1.4.2 to the 1.3.3 version shipped with pack ver 2.6.0:

gtnh-base-chest-nightly486-jabba133-good2-fixvid.mp4

(Taking these captures on Wayland on Linux was amazingly painful.)

Your Proposal

Presumably GTNewHorizons/Jabba#30 is the cause - there has been very little code change in JABBA.

That PR was made to address #15563 . (I haven't put ores in any barrels in my Steam Age base yet.)

Please fix the code so it does not break lighting on vanilla chests. Or, well, my base, I guess.

My base does not use any pipes from the Logistics Pipes mod (AFAIK).

If you'd like my save (~ 260 MiB), tell me and I'll see if I can upload it somewhere along with coords.

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
@leafi leafi added Status: Triage Issue awaiting triage. Remove once this issue is processed Bug: Minor labels May 29, 2024
@leafi
Copy link
Author

leafi commented May 29, 2024

Let me try to fix the videos...

edit should be fixed now

@Quarri6343
Copy link
Member

Tested in dev env, The bug did not occur without Angelica

@Quarri6343 Quarri6343 added Mod: JABBA Mod: Angelica Transfer this issue to the Angelica repo and removed Status: Triage Issue awaiting triage. Remove once this issue is processed labels May 29, 2024
@Quarri6343
Copy link
Member

Found exact why and it is related to Angelica and Vanilla code bad interaction
I'll investigate do other flickering issues relate to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Minor Mod: Angelica Transfer this issue to the Angelica repo Mod: JABBA
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants