jinja2.exceptions package_count error in catalog-web log review

[FuhuXia]

During the recent NewRelic log review, more than 50% of catalog-web errors is this

File "/home/vcap/deps/1/python/lib/python3.9/site-packages/ckan/templates/snippets/organization.html", line 52, in block 'inner'
{% block nums %}
File "/home/vcap/deps/1/python/lib/python3.9/site-packages/ckan/templates/snippets/organization.html", line 60, in block 'nums'
<dd>{{ h.SI_number_span(organization.package_count) }}</dd>
File "/home/vcap/deps/1/python/lib/python3.9/site-packages/ckan/lib/helpers.py", line 2391, in SI_number_span
number = int(number)
jinja2.exceptions.UndefinedError: 'dict object' has no attribute 'package_count'

Sketch

Either fix it, or update the NR rule to ignore it.

[btylerburton]

To reproduce, add a ?q=" to the end of a query within an organization, such as:

https://catalog.data.gov/organization/gsa-gov?q=%22

This does not affect dataset queries such as:

https://catalog.data.gov/dataset?q=%22

At the moment, we're trying to determine if this affects a vanilla CKAN install of 2.10.5.

If yes, we will pursue filing a bug with upstream as this would be a core problem.

If no, then we will attempt to patch this in our own code.

Note that querying SOLR directly with a single double quote will also cause the error "

[btylerburton]

The error from the SOLR query:

  "responseHeader":{
    "status":400,
    "QTime":0,
    "params":{
      "q":"\"",
      "indent":"true",
      "q.op":"OR",
      "_":"1733177831707"}},
  "error":{
    "metadata":[
      "error-class","org.apache.solr.common.SolrException",
      "root-error-class","org.apache.solr.parser.TokenMgrError"],
    "msg":"org.apache.solr.search.SyntaxError: Cannot parse '\"': Lexical error at line 1, column 2.  Encountered: <EOF> after : \"\"",
    "code":400}}

[FuhuXia]

Confirmed a vanilla CKAN 2.10.5. also has this issue.

[btylerburton]

Confirmed a vanilla CKAN 2.10.5. also has this issue.

Given the above, I propose we punt on this issue and start focusing on getting us onto 2.11 which @FuhuXia has tested and confirmed it doesn't have this issue.

Also, since it's a core bug I will post an issue to ckan and see where that leads.

[FuhuXia]

We can set some rules in the NewRelic to ignore this kind of messages from the weekly review.

[btylerburton]

CKAN issue logged here: ckan/ckan#8562

[btylerburton]

We can set some rules in the NewRelic to ignore this kind of messages from the weekly review.

I'm not so sure. A single instance of this error writes 147 logs to NR...

[btylerburton]

Blocked by #4860