Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[82] Submissions List View for Evaluators #319

Open
wants to merge 29 commits into
base: dev
Choose a base branch
from
Open

[82] Submissions List View for Evaluators #319

wants to merge 29 commits into from

Conversation

emmabjj
Copy link
Contributor

@emmabjj emmabjj commented Dec 11, 2024

User story: #82
Dev tasks: #88, #302, #303

As an evaluator, in order to manage submissions and their evaluations process efficiently, I would like to be able to access submissions assigned to me for each challenge.

This PR has the following:

  • Evaluator can see a list of all challenge phases to which they have been assigned submissions
    • challenge phase title
    • number of submissions "assigned to me"
    • number of submissions "remaining to evaluate"
    • due by date
    • evaluate button that navigates to the list of submissions on that phase
  • Evaluator can view a list of submissions they are assigned to evaluate for each challenge
  • Evaluation progress summary (assignment stats)
  • The list of submissions displays:
    • submission ID
    • My submission evaluation status
    • My score
    • Average score (if all evaluators completed their evaluations)

List of challenge phases

Screenshot 2024-12-11 at 1 07 06 AM Screenshot 2024-12-11 at 1 06 27 AM

List of submissions assigned to the evaluator

Screenshot 2024-12-11 at 1 10 47 AM Screenshot 2024-12-11 at 1 12 01 AM

Mobile

Screenshot 2024-12-11 at 1 18 55 AM Screenshot 2024-12-11 at 1 19 49 AM Screenshot 2024-12-11 at 1 19 57 AM

@emmabjj emmabjj self-assigned this Dec 11, 2024
@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 12/17/24 milestone Dec 11, 2024
This was linked to issues Dec 11, 2024
Submissions List View for Evaluators #82
Open
Evaluation Progress Summary for Evaluators #88
Open
Evaluator assigned phases view #302
Open
Evaluator assigned submissions for a phase view #303
Open
@emmabjj emmabjj requested a review from stepchud December 12, 2024 15:47
stepchud
stepchud reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feedback, mostly copy adjustments

app/controllers/evaluator_submission_assignments_controller.rb Outdated Show resolved Hide resolved
app/controllers/evaluations_controller.rb Outdated Show resolved Hide resolved
app/views/shared/_assignment_stats.html.erb Outdated Show resolved Hide resolved
app/helpers/dashboard_helper.rb Outdated Show resolved Hide resolved
app/helpers/evaluations_helper.rb Outdated Show resolved Hide resolved
app/views/evaluations/_phases_table.html.erb Outdated Show resolved Hide resolved
app/views/evaluations/submissions.html.erb Outdated Show resolved Hide resolved
stepchud
stepchud requested changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of blockers and some other feedback

spec/helpers/evaluations_helper_spec.rb Outdated Show resolved Hide resolved
app/helpers/evaluations_helper.rb Outdated Show resolved Hide resolved
app/helpers/evaluations_helper.rb Show resolved Hide resolved
app/views/evaluator_submission_assignments/_unassign_evaluator_submission_modal.html.erb Show resolved Hide resolved
spec/helpers/evaluators_helper_spec.rb
@@ -41,12 +47,18 @@
create(:evaluator_submission_assignment, evaluator: evaluator,
submission: create(:submission, challenge: challenge, phase: phase), status: :unassigned)
create(:evaluator_submission_assignment, evaluator: evaluator,
submission: create(:submission, challenge: challenge, phase: phase), status: :recused)
submission: create(:submission, challenge: challenge, phase: phase), status: :recused_unassigned)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update spec name to recused_unassigned instead?

spec/requests/evaluations_spec.rb Outdated Show resolved Hide resolved
@emmabjj emmabjj requested a review from stepchud January 7, 2025 23:13
@emmabjj emmabjj requested a review from stepchud January 8, 2025 23:10
@emmabjj
Copy link
Contributor Author

emmabjj commented Jan 8, 2025

spec failures are unrelated to this PR

stepchud
stepchud reviewed Jan 9, 2025
View reviewed changes
spec/requests/evaluations_spec.rb
let(:phase) { create(:phase, challenge: challenge) }
let!(:evaluation_form) { create(:evaluation_form, phase: phase, challenge: challenge) }

context "when logged in as an evaluator" do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be good to have a context when logged in as an evaluator that is not associated with the challenge phase to assert access to unrelated phases is denied?

stepchud
stepchud approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add that new spec from my last comment, and this can be merged? 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepchud stepchud stepchud approved these changes

Assignees

@emmabjj emmabjj

Labels
None yet
Projects
None yet
Milestone
Sprint 01/14/25
3 participants
@emmabjj @stepchud @r-bartlett-gsa