Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement proper logging for the traffic data matching #1625

Closed
1 task done
MichaelsJP opened this issue Dec 11, 2023 · 2 comments · Fixed by #1647
Closed
1 task done

Implement proper logging for the traffic data matching #1625

MichaelsJP opened this issue Dec 11, 2023 · 2 comments · Fixed by #1647
Assignees
Labels
easy-fix 👶 very easy fix that should not take much time enhancement | feature ⚡
Milestone

Comments

@MichaelsJP
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

We need traffic data matching statistics.

Proposed solution

Either integrate a log output for the progress or some sensible statistics after logging.

Additional context

No response

Forum Topic Link

No response

@aoles
Copy link
Member

aoles commented Dec 18, 2023

As of ORS v7, the progress bar for map matching of traffic data is redirected from the console output to the logger instance at DEBUG logging level. Effectively, the former interactive progress bar visible during startup of ORS 6.x instance

18 Dec 13:14:05 INFO                                            ORS-pl-car [ r.g.e.s.b.HereTrafficGraphStorageBuilder ]   Starting MapMatching traffic data
Processing traffic patterns 100% │███████████│ 12870/12870 (0:00:00 / 0:00:00) 
Matching Here Links   0% │               │    6000/1190529 (0:00:19 / 1:02:31)

has been replaced by a static sequence of log entries.

18 Dec 12:39:16 INFO                                            ORS-pl-car [ r.g.e.s.b.HereTrafficGraphStorageBuilder ]   Starting MapMatching traffic data
18 Dec 12:39:17 DEBUG                                          ProgressBar [ r.g.e.s.b.HereTrafficGraphStorageBuilder ]   Processing traffic patterns   0% │            │     2/12870 (0:00:00 / 0:00:02) 
18 Dec 12:39:17 DEBUG                                          ProgressBar [ r.g.e.s.b.HereTrafficGraphStorageBuilder ]   Processing traffic patterns 100% │████████████│ 12870/12870 (0:00:00 / 0:00:00) 
18 Dec 12:39:17 DEBUG                                          ProgressBar [ r.g.e.s.b.HereTrafficGraphStorageBuilder ]   Processing traffic patterns 100% │████████████│ 12870/12870 (0:00:00 / 0:00:00) 
18 Dec 12:39:17 DEBUG                                          ProgressBar [ r.g.e.s.b.HereTrafficGraphStorageBuilder ]   Matching Here Links   0% │                      │       0/1190529 (0:00:00 / ?) 
18 Dec 12:39:36 DEBUG                                          ProgressBar [ r.g.e.s.b.HereTrafficGraphStorageBuilder ]   Matching Here Links   0% │                │    2000/1190529 (0:00:19 / 3:08:13) 
18 Dec 12:39:42 DEBUG                                          ProgressBar [ r.g.e.s.b.HereTrafficGraphStorageBuilder ]   Matching Here Links   0% │                │    4000/1190529 (0:00:25 / 2:03:37) 

One possible solution could involve reverting the progress bar to the interactive mode known from ORS v6, but including a summary on the matching success rate in the logger too. These statistics should probably be logged at INFO level.

@MichaelsJP
Copy link
Member Author

OK, nice. So in fact, it's still there, just not in production log files. Yeah. Having it there would be great. What are your thoughts on providing that information additionally in the status endpoint when the graph was built with traffic?

@MichaelsJP MichaelsJP added the easy-fix 👶 very easy fix that should not take much time label Jan 9, 2024
@aoles aoles self-assigned this Jan 12, 2024
@MichaelsJP MichaelsJP added this to the V8 Release milestone Mar 7, 2024
@github-project-automation github-project-automation bot moved this to Awaiting release in ors general Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy-fix 👶 very easy fix that should not take much time enhancement | feature ⚡
Projects
No open projects
Status: Awaiting release
Development

Successfully merging a pull request may close this issue.

2 participants