Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use two database library #746

Open
matthiasschaub opened this issue Nov 28, 2023 · 0 comments · May be fixed by #876
Open

Do not use two database library #746

matthiasschaub opened this issue Nov 28, 2023 · 0 comments · May be fixed by #876
Assignees
@mmerdes @Gigaszi
Labels
code quality Related to our standards for 'good' code

Comments

@matthiasschaub
Copy link
Collaborator

matthiasschaub commented Nov 28, 2023 •
edited by mmerdes
Loading

PR #743 introduced the usage of a second database library psycopg in addition to asyncpg for performance reason. We should only use one library.

Tasks:

  • Stop using asyncpg and remove dependency
  • Move psycopg usage code to the appropriate layer
  • Consider upgrading to psycopg3.

Blocked by: #814
@matthiasschaub matthiasschaub added the code quality Related to our standards for 'good' code label Nov 28, 2023
@matthiasschaub matthiasschaub changed the title Do not use two database library. Do not use two database library Nov 30, 2023
@mmerdes mmerdes mentioned this issue Aug 27, 2024
Open
@matthiasschaub matthiasschaub linked a pull request Feb 5, 2025 that will close this issue
Draft
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmerdes mmerdes

@Gigaszi Gigaszi

Labels
code quality Related to our standards for 'good' code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: psycopg vs asyncpg performance GIScience/ohsome-quality-api
3 participants
@mmerdes @Gigaszi @matthiasschaub