Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve/Fix user interface for attribute completeness #42

Closed
6 of 8 tasks
mmerdes opened this issue Aug 28, 2024 · 0 comments · Fixed by #45
Closed
6 of 8 tasks

Improve/Fix user interface for attribute completeness #42

mmerdes opened this issue Aug 28, 2024 · 0 comments · Fixed by #45

Comments

@mmerdes
Copy link
Contributor

mmerdes commented Aug 28, 2024 •
edited by mcauer
Loading

migrated here from: GIScience/ohsome-quality-api#810

The above-mentioned PR provides oqapi backend functionality for the new 'attribute completeness' feature.
A very basic user interface has already been implemented in this project.

The following improvements are necessary:

  • ui: update input after changing topic (high priority)
  • ui: add label to attribute input field (high priority)
  • ui: move attribute input field to Attribute Completeness section (high priority)
  • ui: show filter after attribute selection (maybe too much / not as important as the above points) (low priority)
  • ui(permalink): attribute is not read after using permalink (medium priority)
  • ui: show selected attribute in result panel (alongside topic and area)
  • ui: make it clear if no attributes are available for a topic (e.g. do not show attribute completeness indicator)
  • Fix CI issues of dashboard (work with PR)
@mmerdes mmerdes mentioned this issue Aug 28, 2024
Merged
11 tasks
mcauer added a commit that referenced this issue Sep 30, 2024
@mcauer
fix: move attribute select field down to indicator
20771fe 
Therefore extracted an SimpleIndicatorComponent wich accepts conditional children (based on indicator-key)

Refs: #42
mcauer added a commit that referenced this issue Sep 30, 2024
@mcauer
fix: move attribute select field down to indicator
c3e622b 
Therefore extracted an SimpleIndicatorComponent wich accepts conditional children (based on indicator-key)

Refs: #42
mcauer added a commit that referenced this issue Oct 22, 2024
@mcauer
fix: attribute completeness dropdown search bar initialization and st…
3a571dc 
…yling

Previously the search bar was not initialized properly when the attribute-completeness indicator was unselected during component initialization. Then search functionality was not available.
Furthermore the height of the text input field for the search was not set propertly because it inherited wrong rules from SemanicCSS's .ui.toggle.checkbox input which is actually meant for input[type=checkbox] but matched out input[type=text] from the search dropdown.

Refs: #42
@mcauer mcauer linked a pull request Oct 25, 2024 that will close this issue
Fix/UI attribute completeness #45
Merged
@mcauer mcauer mentioned this issue Oct 25, 2024
Merged
mcauer added a commit that referenced this issue Oct 25, 2024
@mcauer
fix: move attribute select field down to indicator
158c7ce 
Therefore extracted an SimpleIndicatorComponent wich accepts conditional children (based on indicator-key)

Refs: #42
mcauer added a commit that referenced this issue Oct 25, 2024
@mcauer
fix: move attribute select field down to indicator
2e882e7 
Therefore extracted an SimpleIndicatorComponent wich accepts conditional children (based on indicator-key)

Refs: #42
mcauer added a commit that referenced this issue Oct 25, 2024
@mcauer
fix: attribute completeness dropdown search bar initialization and st…
d9fad2f 
…yling

Previously the search bar was not initialized properly when the attribute-completeness indicator was unselected during component initialization. Then search functionality was not available.
Furthermore the height of the text input field for the search was not set propertly because it inherited wrong rules from SemanicCSS's .ui.toggle.checkbox input which is actually meant for input[type=checkbox] but matched out input[type=text] from the search dropdown.

Refs: #42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/UI attribute completeness GIScience/ohsome-dashboard
1 participant
@mmerdes