From a035c8988119018728cc41c8f099e220387c5dc0 Mon Sep 17 00:00:00 2001 From: "chosw1002@naver.com" Date: Mon, 12 Feb 2024 18:57:24 +0900 Subject: [PATCH] =?UTF-8?q?refactor:=20=EB=A9=A4=EB=B2=84=20=EB=8F=84?= =?UTF-8?q?=EB=A9=94=EC=9D=B8=EC=9D=B4=20dto=EC=97=90=20=EC=9D=98=EC=A1=B4?= =?UTF-8?q?=ED=95=98=EC=A7=80=20=EC=95=8A=EB=8F=84=EB=A1=9D=20=EA=B0=9C?= =?UTF-8?q?=EC=84=A0?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../member/application/MemberService.java | 9 ++++++- .../gdsc/domain/member/domain/Member.java | 24 ++++++++++++------- 2 files changed, 23 insertions(+), 10 deletions(-) diff --git a/src/main/java/com/gdschongik/gdsc/domain/member/application/MemberService.java b/src/main/java/com/gdschongik/gdsc/domain/member/application/MemberService.java index 7fe0b5e93..5d257ce44 100644 --- a/src/main/java/com/gdschongik/gdsc/domain/member/application/MemberService.java +++ b/src/main/java/com/gdschongik/gdsc/domain/member/application/MemberService.java @@ -39,7 +39,14 @@ public void withdrawMember(Long memberId) { public void updateMember(Long memberId, MemberUpdateRequest request) { Member member = memberRepository.findById(memberId).orElseThrow(() -> new CustomException(ErrorCode.MEMBER_NOT_FOUND)); - member.updateMemberInfo(request); + member.updateMemberInfo( + request.studentId(), + request.name(), + request.phone(), + request.department(), + request.email(), + request.discordUsername(), + request.nickname()); } public Page findAllPendingMembers(Pageable pageable) { diff --git a/src/main/java/com/gdschongik/gdsc/domain/member/domain/Member.java b/src/main/java/com/gdschongik/gdsc/domain/member/domain/Member.java index d9aa3a30a..4243f5adf 100644 --- a/src/main/java/com/gdschongik/gdsc/domain/member/domain/Member.java +++ b/src/main/java/com/gdschongik/gdsc/domain/member/domain/Member.java @@ -3,7 +3,6 @@ import static com.gdschongik.gdsc.global.exception.ErrorCode.*; import com.gdschongik.gdsc.domain.common.model.BaseTimeEntity; -import com.gdschongik.gdsc.domain.member.dto.request.MemberUpdateRequest; import com.gdschongik.gdsc.global.exception.CustomException; import jakarta.persistence.Column; import jakarta.persistence.Embedded; @@ -114,16 +113,23 @@ private boolean isForbidden() { return this.status.isForbidden(); } - public void updateMemberInfo(MemberUpdateRequest request) { + public void updateMemberInfo( + String studentId, + String name, + String phone, + String department, + String email, + String discordUsername, + String nickname) { validateStatusUpdatable(); - this.studentId = request.studentId(); - this.name = request.name(); - this.phone = request.phone(); - this.department = request.department(); - this.email = request.email(); - this.discordUsername = request.discordUsername(); - this.nickname = request.nickname(); + this.studentId = studentId; + this.name = name; + this.phone = phone; + this.department = department; + this.email = email; + this.discordUsername = discordUsername; + this.nickname = nickname; } private void validateStatusUpdatable() {