You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
it creates too many instances of OperatorSemaphore. After config changes and moving between screens with "Don't Keep Activities" flag. I tried to trigger GC, but it didn't help.
On the opposite side using
compose(RxTiPresenterUtils.deliverToView(this))
worked just fine. Firstly, it didn't create so many instances, secondly, after triggering GC, the existing instances of OperatorSemaphore was destroyed.
I did look into the internals of caching version it seemed to me that after presenter is destroyed lifecycle observers should be removed therefore triggering GC should clear OperatorSemaphore instances.
Can you better explain how it should work, and when GC should clear out those instances.
Couple of unrelated questions
Should deliverLatestCacheToView propagate cached Error?
Any actions with view in doOnSubscribe/doOnTerminate will crash the app when user will leave and go back to view during network request. I expect isViewReady(presenter) will emit items and deliver cache only when view fully attached.
When using your lib, I noticed weird side-effect, when using
it creates too many instances of OperatorSemaphore. After config changes and moving between screens with "Don't Keep Activities" flag. I tried to trigger GC, but it didn't help.
On the opposite side using
worked just fine. Firstly, it didn't create so many instances, secondly, after triggering GC, the existing instances of OperatorSemaphore was destroyed.
I did look into the internals of caching version it seemed to me that after presenter is destroyed lifecycle observers should be removed therefore triggering GC should clear OperatorSemaphore instances.
Can you better explain how it should work, and when GC should clear out those instances.
Couple of unrelated questions
deliverLatestCacheToView
propagate cached Error?doOnSubscribe/doOnTerminate
will crash the app when user will leave and go back to view during network request. I expect isViewReady(presenter) will emit items and deliver cache only when view fully attached.Full code
The text was updated successfully, but these errors were encountered: