Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paperwork should show actual game mode #415

Open
1 task done
evertiro opened this issue Nov 12, 2024 · 3 comments
Open
1 task done

Paperwork should show actual game mode #415

evertiro opened this issue Nov 12, 2024 · 3 comments
Assignees
Labels
Feature | Paperwork 📜 An issue that is related to the paperwork editor or viewer. Type | Enhancement ⚡ A PR that enhances an existing feature.

Comments

@evertiro
Copy link

Description

Right now, paperwork only shows the game mode listed in mecha's announcement message. It should also show the actual game mode (in case the initial mode is set incorrectly), and potentially also allow changing the game mode in paperwork if it somehow slips through flagged as the wrong mode.

Additional Information (optional)

No response

FuelRats IRC Nickname (optional)

DerekNovak

I can help!

  • I am willing to implement this feature, and submit it as a PR.
@evertiro evertiro added Meta | Needs Attention 🚨 An issue that requires the attention of the maintainers. Type | Feature Request ✨ An issue that requests a new feature. labels Nov 12, 2024
@UncleClapton UncleClapton added Type | Enhancement ⚡ A PR that enhances an existing feature. Feature | Paperwork 📜 An issue that is related to the paperwork editor or viewer. and removed Meta | Needs Attention 🚨 An issue that requires the attention of the maintainers. Type | Feature Request ✨ An issue that requests a new feature. labels Jan 7, 2025
@evertiro
Copy link
Author

Do we want this to simply be displayed? Or do we want to allow it to be changed in the paperwork?

@UncleClapton
Copy link
Member

@evertiro I think it would be worth adding to the editor, but @kenneaal or @SuperManifolds may feel different?

@kenneaal
Copy link
Member

I think the actual data for the case (as opposed to the quotelines) is correct as long as the dispatcher has manipulated the case properly using mecha commands. The announcement quote (or any quotes), IMO, does not need to be changed to reflect the case info.
If there's incorrect data being stored about the paperwork in the platform/mode fields in the database though, that obviously needs to be corrected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature | Paperwork 📜 An issue that is related to the paperwork editor or viewer. Type | Enhancement ⚡ A PR that enhances an existing feature.
Projects
None yet
Development

No branches or pull requests

3 participants