Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 4 / v2 / is this bundle obsolete? #332

Closed
MrQuery opened this issue Dec 5, 2018 · 14 comments
Closed

Symfony 4 / v2 / is this bundle obsolete? #332

MrQuery opened this issue Dec 5, 2018 · 14 comments

Comments

@MrQuery
Copy link

MrQuery commented Dec 5, 2018

hi,
how about tagging a new release version?

The v1.3 is about 2 years old and the master 3 months and has the symfony 4 support.

@MrQuery
Copy link
Author

MrQuery commented Jan 28, 2019

yes? no? maybe? is this project dead?

@RolfBabijn
Copy link

Just bumping this thread, it would be really nice to have a stable release that includes Symfony 4 support.

@hex333ham
Copy link
Collaborator

@MrQuery @Gadgetdude projects not quite dead yet, I've been handed the reigns and it's something I now have time to work on

I'll add the release tag later on this week, want to do some testing on the current state of the project first

@hex333ham hex333ham self-assigned this May 1, 2019
@hex333ham hex333ham added the admin label May 1, 2019
@hex333ham hex333ham added this to the Symfony 4 support milestone May 1, 2019
@hex333ham hex333ham changed the title How about a new release version? tag new version 1.4 Symfony 4 / v1.4 / is this bundle obsolete? May 1, 2019
@hex333ham hex333ham pinned this issue May 1, 2019
@hex333ham
Copy link
Collaborator

righty, I've tidied the issue chain and I'll be doing some updates when I have time

@hex333ham
Copy link
Collaborator

hex333ham commented May 5, 2019

testing complete on 4.0, see #334 for unit/functional/all test results

aiming to have latest complete today (if possible)

@hex333ham
Copy link
Collaborator

hex333ham commented May 5, 2019

moving on to latest version, created documentation on gist for getting setup quickly from what I've just done with 4.0

should work with latest, will update shortly

https://gist.github.com/hex333ham/9fae56fd8f0cdf26f7377a150dc9d72a

@hex333ham
Copy link
Collaborator

4.1 is fine and those instructions work, for details on automated test results see here - #334

@hex333ham
Copy link
Collaborator

hex333ham commented May 5, 2019

release created, doing a test in composer now to verify this working

@hex333ham
Copy link
Collaborator

nevermind, I forgot a few things (need more coffee), deleting that release

@hex333ham
Copy link
Collaborator

hex333ham commented May 5, 2019

alright, never try the easy route (edit in place, bad practice anyway), creating a specific branch for 1.4 to fix deprecation errors - https://github.com/FriendsOfSymfony/FOSMessageBundle/tree/1.4

@hex333ham
Copy link
Collaborator

hex333ham commented May 5, 2019

this is being moved to version 2.0 as I'm going to drop support for Symfony 2 (I can't actually get travis to successfully test on the lowest possible)

see here for when it's going to be deprecated officially by symfony - https://symfony.com/roadmap/2.8

I'll add a note in the docs to use 1.3 if using Symfony2

@hex333ham hex333ham changed the title Symfony 4 / v1.4 / is this bundle obsolete? Symfony 4 / v2 / is this bundle obsolete? May 5, 2019
@hex333ham
Copy link
Collaborator

hex333ham commented May 5, 2019

build is passing when removing symfony 2.8 - #339

may seem sporadic, but I've got one idea for phpunit that might keep support for 2.8

resolved issue with phpunit, but a new one pops up (due to the future deprecation of Controller Symfony4 has made any bundles updating to this incompatible with Symfony3.3 and lower) - #340

going to remove 1.4 branch when 2.0 is released (going to give a couple of days to let people have "objections")

@hex333ham
Copy link
Collaborator

I see no objections, merging to master

@hex333ham
Copy link
Collaborator

merged to master, accidentally created the release (prematurely) so apologies for any notifications occurred from that

I'm now going to close this issue and open a new one for the packagist thing

@hex333ham hex333ham unpinned this issue May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants