From 1ffbb18ba73a201c21027f43409c746d6070f9b5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafa=C5=82=20Ca=C5=82ka?= <25438601+rafaucau@users.noreply.github.com> Date: Wed, 4 Dec 2024 10:40:42 +0100 Subject: [PATCH] fix(optional-policies): calm down some PHPStan errors --- src/Repositories/PolicyRepository.php | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Repositories/PolicyRepository.php b/src/Repositories/PolicyRepository.php index eee59ef..11bf239 100644 --- a/src/Repositories/PolicyRepository.php +++ b/src/Repositories/PolicyRepository.php @@ -59,13 +59,9 @@ public function clearCache() $this->cache->forget(self::CACHE_KEY); } - /** - * @param string $id - * - * @return Policy - */ public function findOrFail(string $id): Policy { + /** @phpstan-ignore-next-line Method FoF\Terms\Repositories\PolicyRepository::findOrFail() should return FoF\Terms\Policy but returns Illuminate\Database\Eloquent\Model. */ return $this->policy->newQuery()->findOrFail($id); } @@ -82,10 +78,14 @@ public function state(User $user) $this->rememberState = []; foreach ($this->all() as $policy) { + /** @phpstan-ignore-next-line Access to an undefined property FoF\Terms\Policy::$pivot */ $accepted_at = $userPolicies->has($policy->id) ? Carbon::parse($userPolicies->get($policy->id)->pivot->accepted_at) : null; $has_update = !$accepted_at || (($policy->terms_updated_at !== null) && $policy->terms_updated_at->gt($accepted_at)); $optional = $policy->optional; - /** @var bool $is_accepted */ + /** + * @var bool $is_accepted + * @phpstan-ignore-next-line Access to an undefined property FoF\Terms\Policy::$pivot + */ $is_accepted = $userPolicies->has($policy->id) ? $userPolicies->get($policy->id)->pivot->is_accepted : false; $this->rememberState[$policy->id] = [