Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion Language breaks flarum/tags feature "Hide from All Discussions" #27

Open
iPurpl3x opened this issue Apr 7, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@iPurpl3x
Copy link
Contributor

iPurpl3x commented Apr 7, 2022

Bug Report

Current Behavior
When using Discussion Language, the "Hide from All Discussions" option of flarum/tags seems to be ignored.

Steps to Reproduce

  1. Create a tag with "Hide from All Discussions" enabled
  2. Create a discussion in this tag
  3. Navigate to "All discussions"
  4. See that the created discussion is visible in the list
  5. Disable Discussion Language
  6. See that now the discussion is hidden, as expected.

Expected Behavior
"Hide from All Discussions" should work as expected.

Environment

  • Flarum version: 1.2.1
  • Extension version: 1.2.5
  • PHP version: 8
@iPurpl3x iPurpl3x added the bug Something isn't working label Apr 7, 2022
@dsevillamartin
Copy link
Member

dsevillamartin commented Apr 7, 2022

This might be because the "All Discussions" page is not supposed to have any filters. As this extension adds a filter, it may no longer be recognized as all discussions page.

Not sure how to resolve this.

Might need specific code for tags to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants