Fix compiler warnings with optimizations enabled #1218
+39
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will create warnings on compilers that always warn on strcpy. Do we have Clang in CI? If it doesnt warn on the compilers we we support, should be fine. |
@archigup do you think memcpy() would be the better choice? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes compiler warnings that are generated when compiled with optimizations enabled in GCC and adds CI build checks with optimization settings on.
Thanks, @StefanBalt, for reporting this issue in #1217.
Test Steps
Tested with DNS
Checklist:
[ ] I have modified and/or added unit-tests to cover the code changes in this Pull Request.Related Issue
#1217
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.