Wrong test in function prvTCPSendLoop() #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS. I found the guilty PR: #317, mea culpa. |
ActoryOu
previously approved these changes
Nov 13, 2023
moninom1
previously approved these changes
Nov 13, 2023
tony-josi-aws
previously approved these changes
Nov 13, 2023
aggarg
previously approved these changes
Nov 14, 2023
|
Would be good to run iperf before merge |
tony-josi-aws
dismissed stale reviews from aggarg, moninom1, ActoryOu, and themself
via
b652f75
tony-josi-aws
approved these changes
Nov 14, 2023
aggarg
approved these changes
Nov 14, 2023
htibosch
added a commit
to htibosch/FreeRTOS-Plus-TCP
that referenced
this pull request
Nov 21, 2023
Wrong test in function prvTCPSendLoop() (FreeRTOS#1043)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks to a forum user zugo83 in a post in the FreeRTOS Forum, we saw that the function
FreeRTOS_send()would last longer than necessary.The proposed change is as follows:
xBytesLeft -= xByteCount; xBytesSent += xByteCount; - if( ( xBytesLeft == 0 ) && ( pvBuffer == NULL ) ) + if( ( xBytesLeft == 0 ) || ( pvBuffer == NULL ) ) { /* pvBuffer can be NULL in case TCP zero-copy transmissions are used. */ break; }This must have been a type that happened when we merged the trees IPv4 with IPv6/multi.
Test Steps
Try send loads of data before and after this change.
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.