Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border prop #26

Open
lehresman opened this issue Aug 16, 2019 · 0 comments
Open

Add border prop #26

lehresman opened this issue Aug 16, 2019 · 0 comments

Comments

@lehresman
Copy link

Is your feature request related to a problem? Please describe.

No

Describe the solution you'd like

The web version of react-fontawesome has a border prop that sets the border class. I am needing a similar feature for react-native-fontawesome. Bonus points for easily setting the border color.

Describe alternatives you've considered

I thought about layering two icons on top of each other, having the bottom one slightly bigger to be my border. But that doesn't work correctly around all curves. The scaling ratio is different. It's also kind of a hack.

Additional context

I am using faMapMarker as a pin on top of a Google map. Works great, since FontAwesome icons are just svgs. However, to make the icon look right and stand out on them map, I need to set a white border.

@lehresman lehresman changed the title Add border option Add border prop Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant