Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: MacOS runner #172

Closed
nichollsh opened this issue Sep 5, 2024 · 4 comments · Fixed by #198
Closed

Tests: MacOS runner #172

nichollsh opened this issue Sep 5, 2024 · 4 comments · Fixed by #198
Labels
enhancement New feature or request

Comments

@nichollsh
Copy link
Contributor

It would be useful to setup the tests to run a matrix of different Linux and Python versions, in order to catch potential issues which arise only for certain platforms.

C.f. FormingWorlds/MORS#22

@nichollsh
Copy link
Contributor Author

At the same time, we should use V4 of the Cache action, since the current V3 has some significant slowness when doing the post-job clean up step. I have noticed that the action seems to 'hang' for several minutes after the cache step has completed, which has also been noted here: actions/toolkit#1578 (comment).

@nichollsh
Copy link
Contributor Author

The above issue with Cache V4 has been resolved.

Seems like the only runner images are Ubuntu, MacOS, and windows. We could add a MacOS one, but unfortunately the Linux side is limited to Ubuntu. There's no planned support for Windows, since they can just use WSL.

@nichollsh nichollsh changed the title Update tests to run on different linux versions Tests: MacOS runner Sep 14, 2024
@stefsmeets
Copy link
Contributor

What issues do you expect on a non-ubuntu linux?

@nichollsh
Copy link
Contributor Author

I don't have any in mind specifically, but the issue that Laurent has been facing (MORS getting different values on different platforms, despite being pure Python) indicates that this is something that we should consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants