fix reason check in field::send_to(uint16 step #580
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#334
#516
As we have seen before, dividing the reason into effect/cost is not enough.
The reason for release now:
REASON_ACTION
"This card cannot declare an attack unless"... (Panther Warrior)
REASON_COST
The card is released by the cost of effect activation.
Prohibited by
Ritual Beast Ulti-Reirautari
.REASON_EFFECT
The card is released by effect. (Ritual Summon)
REASON_MAINTENANCE
The maintenance cost. (Aerial Recharge)
REASON_SPSUMMON
The card is released by the Special Summon procedure. (Blue-Eyes Toon Dragon)
REASON_SUMMON
The card is released by Tribute Summon.
REASON_RULE
The card is is released by non-effect actions. (痛み分け/Share the Pain)
They should be applied to
Duel.Sendto*
, as @465uytrewq suggested in Fluorohydride/ygopro-scripts#2366 .Now it will check
pcard->is_affect_by_effect
only when the move is marked byREASON_EFFECT
.Test script:
@mercury233
@purerosefallen