Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cost to EFFECT_TRAP_ACT_IN_HAND #575

Merged

Conversation

purerosefallen
Copy link
Collaborator

@purerosefallen purerosefallen commented Apr 7, 2024

Added cost to effects like EFFECT_TRAP_ACT_IN_HAND, to deal with traps acting in hand like Red Reboot or Ebon High Magician.

Same things also did to EFFECT_QP_ACT_IN_NTPHAND EFFECT_TRAP_ACT_IN_SET_TURN EFFECT_QP_ACT_IN_SET_TURN

In addition, when multiple effects available to act in set turn or hand, the player would be asked to choose one to apply.

function c85551711.handcost(e,tp,eg,ep,ev,re,r,rp,chk,te)

end

@salix5
Copy link
Collaborator

salix5 commented Apr 30, 2024

@mercury233

@DailyShana
Copy link
Contributor

DailyShana commented Apr 30, 2024

#254 almost solve this issue
I think effect_set effect::required_handorset_effects is unnecessary, see #254

@purerosefallen
Copy link
Collaborator Author

purerosefallen commented May 2, 2024

@DailyShana required_handorset_effects is something to make code clean, to avoid checking effects in two places.

in addition, I prefer to make the cost as a standard cost format e,tp,eg,ep,ev,re,r,rp,chk. And, I perfer to make a new one rather than resolving conflicts in #254

@purerosefallen purerosefallen merged commit 0e3d5d1 into Fluorohydride:master May 7, 2024
1 check passed
@purerosefallen purerosefallen deleted the patch-trap-setinturn branch May 13, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants