Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIKIT define #7

Closed
raberm opened this issue Oct 22, 2016 · 2 comments
Closed

UIKIT define #7

raberm opened this issue Oct 22, 2016 · 2 comments

Comments

@raberm
Copy link
Contributor

raberm commented Oct 22, 2016

HandySwift sets OTHER_SWIFT_FLAGS = "-D UIKIT"; on the project file, then checking with #if UIKIT.
This version might be easier to handle as it needs no flags (Cocoapods didn't set it up for me, fe)

#if os(iOS) || os(tvOS)

@Jeehut
Copy link
Member

Jeehut commented Oct 23, 2016

You're absolutely right, that would be a better solution now, I simply forgot to update that part when migrating to newer Swift versions, where the if os(platform) was introduced. Good catch!

Would you mind implementing tha change yourself and sending in a pull request? I would gladly merge it and release a new version. 👍

@Jeehut
Copy link
Member

Jeehut commented Oct 27, 2016

Fixed via #8 – this issue should be solved in the next version update. Do you need one urgently – or, to ask differently, did you find a workaround for this issue? Otherwise I'd wait until other features are added / bugs are fixed and release then.

@Jeehut Jeehut closed this as completed Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants