Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File headers don't match shared format #31

Closed
fredpi opened this issue May 7, 2019 · 2 comments · Fixed by #34
Closed

File headers don't match shared format #31

fredpi opened this issue May 7, 2019 · 2 comments · Fixed by #34
Assignees
@fredpi

Comments

@fredpi
Copy link
Contributor

fredpi commented May 7, 2019

Some file headers match the old file header format, e. g.:

//
//  Unowned.swift
//  HandySwift
//
//  Created by Murat Yilmaz on 19.05.18.
//  Copyright © 2018 Flinesoft. All rights reserved.
//

instead of:

//
//  Created by Murat Yilmaz on 19.05.18.
//  Copyright © 2018 Flinesoft. All rights reserved.
//

Is this intentional, or should we adjust old headers to the new format?
@Jeehut
Copy link
Member

Jeehut commented May 7, 2019 •
edited
Loading

We've even gone further and now just use this (see here):

//  Copyright © 2018 Flinesoft. All rights reserved.

There's no intention behind that, it's just a leftover. Feel free to fix! 💯

@fredpi
Copy link
Contributor Author

fredpi commented May 7, 2019

Will create a PR soon ;)

@fredpi fredpi self-assigned this May 8, 2019
@fredpi fredpi mentioned this issue May 10, 2019
Merged
Jeehut added a commit that referenced this issue May 13, 2019
@Jeehut
Merge pull request #34 from Flinesoft/work/#31-file-headers
46cf615 
File Headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fredpi fredpi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

File Headers FlineDev/HandySwift
2 participants
@Jeehut @fredpi