Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Comparable.clamped(to:) and Comparable.clamp(to:) #32

Merged
merged 5 commits into from
May 8, 2019
Merged

Implement Comparable.clamped(to:) and Comparable.clamp(to:) #32

merged 5 commits into from
May 8, 2019

Conversation

fredpi
Copy link
Contributor

@fredpi fredpi commented May 7, 2019

Closes #30.

Jeehut
Jeehut reviewed May 7, 2019
View reviewed changes
Copy link
Member

@Jeehut Jeehut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One detail, looks good otherwise.

Jeehut
Jeehut approved these changes May 8, 2019
View reviewed changes
Copy link
Member

@Jeehut Jeehut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to merge now. Just a small comment which you might decide to fix up or not, it's your choice. Feel free to merge yourself.

@fredpi fredpi merged commit 839d8e4 into FlineDev:stable May 8, 2019
@fredpi fredpi deleted the work/#30-clamped branch May 8, 2019 22:15
@fredpi fredpi mentioned this pull request May 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeehut Jeehut Jeehut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Comparable.bounded(lower:upper:) interface
2 participants
@fredpi @Jeehut