batchSet and transactionSet should rely on castedReference like set #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37
In generated code, relying on
batch.set(reference, json, options);
forbatchSet
implementation is wrong because we pass aDocumentReference<T>
with T a mapping class as a reference with a json data. Cloud_firestore then try to apply the converter but data is already in json. Seewrite_batch.dart
from cloud_firestore, line 56.batch.set(reference, json, options);
Should be replaced with :
Like it's done for set method. Same for transaction.