Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[firestore-shorten-urls-dynamic-links] Regex validation on DYNAMIC_LINKS_URL_PREFIX #13

Open
joehan opened this issue Jan 14, 2021 · 1 comment
Open

[firestore-shorten-urls-dynamic-links] Regex validation on DYNAMIC_LINKS_URL_PREFIX #13

joehan opened this issue Jan 14, 2021 · 1 comment
Assignees
@kevinthecheung @cabljac
Labels
extension:firestore-shorten-urls-dynamic-links

Comments

@joehan
Copy link

joehan commented Jan 14, 2021 •
edited by jhuleatt
Loading

Expected Behavior

There should be some validationRegex for this parameter, since we know it should look likehttps://*.page.link

Actual Behavior

There isn't any validation. If you try to install with something invalid, the extension deploys correctly but sets shortUrl to undefined every time it triggers.

Specifications

  • Extension name: firestore-shorten-urls-dynamic-links
  • Version: 0.1.1
@jhuleatt
Copy link
Collaborator

FYI @kevinthecheung

@cabljac cabljac self-assigned this Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinthecheung kevinthecheung

@cabljac cabljac

Labels
extension:firestore-shorten-urls-dynamic-links
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jhuleatt @joehan @kevinthecheung @cabljac