New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interface improvements #49

Open

Fetz opened this issue Jun 6, 2018 · 1 comment

Labels

enhancement quality

Owner

Fetz commented Jun 6, 2018 •

edited

Loading

CLI and Node/Browser options should match

CLI	Node/Browser
--depth	maxDepth

Node/Browser JSON option, since is mandatory and the other aren't we should make it the first argument and the second should be all the non mandatory, it will make more closer to the behaviour of the CLI
Node/Browser JSON option shouldn't be called JSON or we should convert it not in the cli but in the Node/Browser library code and add there the validation
We should rename the cli (in the package) from json-analyzer.js to json-analyzer

Would be useful to do this before doing the asciicinema/svg-term-cli animations in the README and gh-page

The text was updated successfully, but these errors were encountered:

Fetz added the enhancement label

Fetz added the quality label

Owner Author

Fetz commented Jun 13, 2018

work in progress: https://github.com/Fetz/json-analyzer/tree/feature/issue-49-interface-improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment