Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken with Gradle 8.12 #4

Open
RubixDev opened this issue Jan 6, 2025 · 2 comments
Open

Broken with Gradle 8.12 #4

RubixDev opened this issue Jan 6, 2025 · 2 comments

Comments

@RubixDev
Copy link

RubixDev commented Jan 6, 2025

Gradle 8.12 introduced a hard error when private methods are annotated with @TaskAction or similar annotations. This is the case in this plugin for the doConversion method:

@TaskAction
private void doConversion()
{

Gradle Output
FAILURE: Build failed with an exception.

* What went wrong:
A problem was found with the configuration of task ':1.20.6:yamlangConvertMainResources' (type 'YamlangConvertor').
  - Method 'doConversion' is private and annotated with @TaskAction.
    
    Reason: Annotations on private methods are ignored.
    
    Possible solutions:
      1. Make the method public.
      2. Annotate the public version of the method.
    
    For more information, please refer to https://docs.gradle.org/8.12/userguide/validation_problems.html#private_method_must_not_be_annotated in the Gradle documentation.
@Fallen-Breath
Copy link
Owner

If I understand correctly, what I need to do is simply change the "private" to "public", right?

@RubixDev
Copy link
Author

RubixDev commented Jan 7, 2025

If I understand correctly, what I need to do is simply change the "private" to "public", right?

it sounds like that to me, but i don't have any experience with writing Gradle plugins myself, I just wanted to let you know about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants