From c0c1cfe597b2ce9bfcbf8ddb5f69e810bb92d301 Mon Sep 17 00:00:00 2001 From: somya51p Date: Thu, 21 Apr 2022 17:14:18 +0530 Subject: [PATCH] code quality improvised --- changes.patch | 36 ------------------------------ src/components/Plugins/Plugins.jsx | 20 +++++++---------- 2 files changed, 8 insertions(+), 48 deletions(-) delete mode 100644 changes.patch diff --git a/changes.patch b/changes.patch deleted file mode 100644 index 30b1df06..00000000 --- a/changes.patch +++ /dev/null @@ -1,36 +0,0 @@ -diff --git a/changes.patch b/changes.patch -index 66e4f60..e69de29 100644 ---- a/changes.patch -+++ b/changes.patch -@@ -1,18 +0,0 @@ --diff --git a/src/components/Plugins/Plugins.jsx b/src/components/Plugins/Plugins.jsx --index ad318e6..0018821 100644 ----- a/src/components/Plugins/Plugins.jsx --+++ b/src/components/Plugins/Plugins.jsx --@@ -416,11 +416,11 @@ export class Plugins extends Component { --

-- {pluginsCount} plugins found --

--- Showing {paginationOffset + 1} to {' '} --+ Showing {Math.min(pluginsCount, paginationOffset + 1} to {' '} -- { -- // eslint-disable-next-line no-nested-ternary -- (paginationOffset + paginationLimit > plugins.totalCount) ? --- (plugins.totalCount === -1 ? 1 : plugins.totalCount) --+ pluginsCount -- : -- (paginationOffset > 0) ? -- paginationOffset -diff --git a/src/components/Plugins/Plugins.jsx b/src/components/Plugins/Plugins.jsx -index ddea2f9..51047d2 100644 ---- a/src/components/Plugins/Plugins.jsx -+++ b/src/components/Plugins/Plugins.jsx -@@ -419,7 +419,7 @@ export class Plugins extends Component { - Showing {Math.min(pluginsCount, paginationOffset + 1)} to {' '} - { - // eslint-disable-next-line no-nested-ternary -- (paginationOffset + paginationLimit > plugins.totalCount) ? -+ (paginationOffset + paginationLimit > pluginsCount) ? - pluginsCount - : - (paginationOffset > 0) ? diff --git a/src/components/Plugins/Plugins.jsx b/src/components/Plugins/Plugins.jsx index 51047d2d..1f58e0da 100644 --- a/src/components/Plugins/Plugins.jsx +++ b/src/components/Plugins/Plugins.jsx @@ -369,7 +369,13 @@ export class Plugins extends Component { ) const pluginsCount=plugins.totalCount > 0 ? plugins.totalCount : 0; - + const pluginsLast=(paginationOffset + paginationLimit > pluginsCount) ? + pluginsCount + : + (paginationOffset > 0) ? + paginationOffset + : + paginationLimit; return (
@@ -416,17 +422,7 @@ export class Plugins extends Component {

{pluginsCount} plugins found

- Showing {Math.min(pluginsCount, paginationOffset + 1)} to {' '} - { - // eslint-disable-next-line no-nested-ternary - (paginationOffset + paginationLimit > pluginsCount) ? - pluginsCount - : - (paginationOffset > 0) ? - paginationOffset - : - paginationLimit - } + Showing {Math.min(pluginsCount, paginationOffset + 1)} to {pluginsLast} ) }