/types endpoints are inconsistently applying local

[jason-fox]

Orion 1.6 -

I have a context broker and an IoT Agent.
context broker initially holds people, agri-parcels and buildings.

http://localhost:1026/ngsi-ld/v1/types returns:

{
    "id": "urn:ngsi-ld:EntityTypeList:04fed336-a679-11ef-b107-0242ac12010a",
    "type": "EntityTypeList",
    "typeList": [
        "https://schema.org/Person",
        "https://smartdatamodels.org/dataModel.Agrifood/AgriParcel",
        "https://smartdatamodels.org/dataModel.Building/Building"
    ]
}

When I add a REDIRECT registration to Farmer (which only holds Animals and run /types again. I get Animal added to the list:

{
    "id": "urn:ngsi-ld:EntityTypeList:04fed336-a679-11ef-b107-0242ac12010a",
    "type": "EntityTypeList",
    "typeList": [
        "https://schema.org/Person",
        "https://smartdatamodels.org/dataModel.Agrifood/AgriParcel",
        "https://smartdatamodels.org/dataModel.Agrifood/Animal",
        "https://smartdatamodels.org/dataModel.Building/Building"
    ]
}

So far so good. ✅

But if I run http://localhost:1026/ngsi-ld/v1/types?local=true I still get Animals in the list which is wrong. ❌

I have the reverse issue with an EXCLUSIVE registration. My context broker runs the following Registration:

curl --location 'http://localhost:1027/ngsi-ld/v1/csourceRegistrations/' \
--header 'Link: <http://context/ngsi-context.jsonld>; rel="http://www.w3.org/ns/json-ld#context"; type="application/ld+json' \
--header 'Content-Type: application/json' \
--data '{
    "type": "ContextSourceRegistration",
    "information": [
        {
            "entities": [
                {
                    "type": "Animal",
                    "id": "urn:ngsi-ld:Animal:cow001"
                }
            ],
            "propertyNames": [
                "heartRate",
                "location"
            ]
        }
    ],
    "mode": "exclusive",
    "operations": [
        "retrieveOps"
    ],
    "endpoint": "http://devices",
    "contextSourceInfo": [
        {
            "key": "jsonldContext",
            "value": "http://context/ngsi-context.jsonld"
        }
    ]
}'

However when I run

curl --location 'http://localhost:1026/ngsi-ld/v1/types/Animal' \
--header 'Link: <http://context/ngsi-context.jsonld>; rel="http://www.w3.org/ns/json-ld#context"; type="application/ld+json'

The new attributes of heartRate and location are not to be found ❌ - so this appears to be automatically applying local=true in this case.

The ETSI Spec is quite clear that local=true is required for /types:

6.3.18 Limiting Distributed Operations

The parameter described in this clause limits the execution of an operation to a local Context Source or
Context Broker (clause 5.5.13). It amends the matching Context Source Registrations behaviour as described
in clause 5.12, in the case of the HTTP binding in order to avoid cascading distributed operations (see
clause 4.3.6.4). For all operations the resources /entities/, /types/, /attributes/, /entityOperations/,
/temporal/entities/ and temporal/entityOperations/ (and their respective child resources) implementations
shall support the HTTP query parameter specified in Table 6.3.18-1.

[kzangeli]

First part done (local URI param for types discovery)

[kzangeli]

Second part done in #1722