Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revise text about column ordering #175

Closed
grahamegrieve opened this issue Oct 29, 2023 · 2 comments
Closed

revise text about column ordering #175

grahamegrieve opened this issue Oct 29, 2023 · 2 comments

Comments

@grahamegrieve
Copy link
Contributor

Column ordering: ViewDefinition runners MUST produce columns in the same order as they appear in the views.

I think 'views' isn't the right word in that sentence.

Also, given that not all runners produce ordered sets of columns, I think that this needs some qualification

@johngrimes
Copy link
Collaborator

The text has changed since this issue was created, it now reads:

ViewDefinition runners MUST produce output in the same order as the column structures seen in the ViewDefinition instances.

The other perhaps pertinent change has been to require column names within view definitions.

In the context of this, why is it desirable to require deterministic column ordering in the output?

@johngrimes
Copy link
Collaborator

I think this has now been resolved by #208.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants