From d938e61a1e0c7a07239b9591441b01d9d755c2a7 Mon Sep 17 00:00:00 2001
From: Sheikah45 <Sheikah450@gmail.com>
Date: Fri, 17 Nov 2023 17:27:12 -0500
Subject: [PATCH] Disable flaky tests

---
 .../client/filter/FilterMultiCheckboxControllerTest.java        | 2 ++
 .../com/faforever/client/vault/VaultEntityControllerTest.java   | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/src/test/java/com/faforever/client/filter/FilterMultiCheckboxControllerTest.java b/src/test/java/com/faforever/client/filter/FilterMultiCheckboxControllerTest.java
index 9bd5f7bbf0..2049fd4aac 100644
--- a/src/test/java/com/faforever/client/filter/FilterMultiCheckboxControllerTest.java
+++ b/src/test/java/com/faforever/client/filter/FilterMultiCheckboxControllerTest.java
@@ -5,6 +5,7 @@
 import javafx.beans.property.ListProperty;
 import javafx.util.StringConverter;
 import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.mockito.InjectMocks;
 import org.mockito.Mock;
@@ -60,6 +61,7 @@ public void testResetFilter() {
   }
 
   @Test
+  @Disabled("Flaky on github")
   public void testCheckUncheckItemsWithUsingSearchBar() {
     runOnFxThreadAndWait(() -> instance.setItems(IntStream.rangeClosed(1, 10).boxed().toList()));
     runOnFxThreadAndWait(() -> {
diff --git a/src/test/java/com/faforever/client/vault/VaultEntityControllerTest.java b/src/test/java/com/faforever/client/vault/VaultEntityControllerTest.java
index 17195bdabb..c572ec81d3 100644
--- a/src/test/java/com/faforever/client/vault/VaultEntityControllerTest.java
+++ b/src/test/java/com/faforever/client/vault/VaultEntityControllerTest.java
@@ -179,6 +179,7 @@ public void testOnDisplay() {
   }
 
   @Test
+  @Disabled("Flaky on github")
   public void testEmptyShowRoom() {
     items = IntStream.range(0, 0).boxed().toList();
     runOnFxThreadAndWait(() -> instance.display(new NavigateEvent(NavigationItem.MAP)));
@@ -204,6 +205,7 @@ public void testPagination() {
   }
 
   @Test
+  @Disabled("Flaky on github")
   public void testLastPageButton() {
     runOnFxThreadAndWait(() -> instance.display(new NavigateEvent(NavigationItem.MAP)));
     WaitForAsyncUtils.waitForFxEvents();