Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible false positive for AdMob when only com.google.gms:google-services are required #100

Open
ignisf opened this issue Jan 13, 2025 · 2 comments
Labels

Comments

@ignisf
Copy link

ignisf commented Jan 13, 2025

Hi,

I noticed that the brand new Pixelfed client (com.pixelfed https://github.com/pixelfed/pixelfed-rn/tree/main/android ) gets flagged as having a tracker ( https://reports.exodus-privacy.eu.org/en/reports/548417/#trackers ).

I sprinkled some debugging in the standalone exodus version and ran it locally on the APK, it pointed out this:

DEBUG:root:Google AdMob tracker detected in com/google/ads/interactivemedia/v3/api/AdErrorEvent

Does this look like a false positive to you? Maybe this class is a dependency of google-services and it gets detected without the app actually having ads?

@codeurimpulsif
Copy link
Contributor

codeurimpulsif commented Jan 13, 2025

Hi @ignisf and thanks for this issue.

Looking at it and it seems to be a class added by some dependency like google-services you're right.

It's flag by the detection rule Google AdMob with com.google.ads..

I don't think it's a false positive, as we explain here:
"Our static detection method looks in applications for the presence of a defined list of trackers […] This is not a proof of activity of these trackers."

Looking at the Pixelfed-rn code it seems to never be initialized or called, so this AdMob tracker is "present" in the app but not "activate".

We keep looking for good ways to inform about that (the fact that "present" doesn't mean "active") but it's not easy (also because we're only a very small team without lot of time).

I also ping @pnu-s and maybe @U039b for good advices on how to remove this kind of classes embeded by dependencies?

@ignisf
Copy link
Author

ignisf commented Jan 17, 2025

@codeurimpulsif, thank you for your time and your kind and detailed response! I see that this is indeed expected, so please feel free to close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants