-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
please document SCReAM algorithm plugin #58
Comments
Thanks.
Yes it is true that the OWR implementation lags behind, hope that I will be able to update OWR one day.
Regards
/Ingemar
From: Jonas Smedegaard [mailto:[email protected]]
Sent: den 17 mars 2017 10:41
To: EricssonResearch/openwebrtc-gst-plugins <[email protected]>
Cc: Subscribed <[email protected]>
Subject: [EricssonResearch/openwebrtc-gst-plugins] please document SCReAM algorithm plugin (#58)
This project includes an implementation of the SCReAM - awesome!!!
It seems, however, that the implementation is somewhat behind the C++ library implementation at https://github.com/EricssonResearch/scream. I do understand that this is highly experimental code, and imagine that the main focus is therefore on development and consumption by others is not a high priority (if a priority/possibility at all). In any case, I suggest to add a (brief, at least) documentation on the status of this module - and if in a usable state then a concrete example.
Thanks for the exciting work you are doing in this field!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#58>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AKOdGH_sxRsWFOJi642wxPfRlhP948AWks5rmlUugaJpZM4MgXuY>.
|
Quoting IngJohEricsson (2017-03-20 14:25:43)
Yes it is true that the OWR implementation lags behind, hope that I
will be able to update OWR one day.
Thanks for confirming, and great if you can find time to improve, but
please not that the issue I raised here was a different - and simpler, I
hope - one of mentioning at the front README.md that this project
includes an implementation of SCReAM.
- Jonas
…--
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
|
OK, fixed this
/Ingemar
From: Jonas Smedegaard [mailto:[email protected]]
Sent: den 20 mars 2017 15:15
To: EricssonResearch/openwebrtc-gst-plugins <[email protected]>
Cc: Ingemar Johansson S <[email protected]>; Comment <[email protected]>
Subject: Re: [EricssonResearch/openwebrtc-gst-plugins] please document SCReAM algorithm plugin (#58)
Quoting IngJohEricsson (2017-03-20 14:25:43)
Yes it is true that the OWR implementation lags behind, hope that I
will be able to update OWR one day.
Thanks for confirming, and great if you can find time to improve, but
please not that the issue I raised here was a different - and simpler, I
hope - one of mentioning at the front README.md that this project
includes an implementation of SCReAM.
- Jonas
…--
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#58 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AKOdGPTwiUNA8N9iPBeCFN_U6jZxn54Lks5rnonGgaJpZM4MgXuY>.
|
Quoting IngJohEricsson (2017-03-22 09:32:07)
OK, fixed this
It seems you extended the README.md for
<https://github.com/EricssonResearch/scream>
There is still no mention of SCReAM in the README.md for
<https://github.com/EricssonResearch/openwebrtc-gst-plugins>.
- Jonas
…--
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
|
Yes.. sorry, misunderstood it.
I will try to get time for a major overhaul of the owr-gst-plugin later on and fix the readme then.
/Ingemar
From: Jonas Smedegaard [mailto:[email protected]]
Sent: den 22 mars 2017 19:16
To: EricssonResearch/openwebrtc-gst-plugins <[email protected]>
Cc: Ingemar Johansson S <[email protected]>; Comment <[email protected]>
Subject: Re: [EricssonResearch/openwebrtc-gst-plugins] please document SCReAM algorithm plugin (#58)
Quoting IngJohEricsson (2017-03-22 09:32:07)
OK, fixed this
It seems you extended the README.md for
<https://github.com/EricssonResearch/scream>
There is still no mention of SCReAM in the README.md for
<https://github.com/EricssonResearch/openwebrtc-gst-plugins>.
- Jonas
…--
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#58 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AKOdGK1JFp27iInaNwqOpSs7Js1sOUOVks5roWVcgaJpZM4MgXuY>.
|
Quoting IngJohEricsson (2017-03-24 10:25:14)
Yes.. sorry, misunderstood it.
I will try to get time for a major overhaul of the owr-gst-plugin later on and fix the readme then.
Sounds great. Thanks!
…--
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This project includes an implementation of the SCReAM - awesome!!!
It seems, however, that the implementation is somewhat behind the C++ library implementation at https://github.com/EricssonResearch/scream. I do understand that this is highly experimental code, and imagine that the main focus is therefore on development and consumption by others is not a high priority (if a priority/possibility at all). In any case, I suggest to add a (brief, at least) documentation on the status of this module - and if in a usable state then a concrete example.
Thanks for the exciting work you are doing in this field!
The text was updated successfully, but these errors were encountered: