Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run static code analysis on commits #668

Closed
wbqpk3 opened this issue Nov 6, 2023 · 3 comments · Fixed by #719
Closed

Run static code analysis on commits #668

wbqpk3 opened this issue Nov 6, 2023 · 3 comments · Fixed by #719
Labels
Target: Developer environment Developer environment issues consist of CodeCompass or 3rd-party build tooling, configuration or CI.

Comments

@wbqpk3
Copy link
Collaborator

wbqpk3 commented Nov 6, 2023

See the OpenSSF security test (#659).

{
      "details": [
        "Warn: 0 commits out of 23 are checked with a SAST tool",
        "Warn: CodeQL tool not detected"
      ],
      "score": 0,
      "reason": "SAST tool is not run on all commits -- score normalized to 0",
      "name": "SAST",
      "documentation": {
        "url": "https://github.com/ossf/scorecard/blob/main/docs/checks.md#sast",
        "short": "Determines if the project uses static code analysis."
      }
    }
@mcserep mcserep added the Target: Developer environment Developer environment issues consist of CodeCompass or 3rd-party build tooling, configuration or CI. label Nov 8, 2023
@mcserep
Copy link
Collaborator

mcserep commented Nov 8, 2023

Enabled CodeQL with the default configuration for now, as described here:
https://docs.github.com/en/code-security/code-scanning/enabling-code-scanning/configuring-default-setup-for-code-scanning

Just to see what will it report at all, and also because I am not familiar with CodeQL's configuration options.
Bit excited what result will this produce 😄

@mcserep
Copy link
Collaborator

mcserep commented Nov 8, 2023

Okay, so that is not that easy as it seemed, the default automatic configuration did not work for the C++ and the Java sources, stating it could not figure out the proper build command, so it has to be configured manually.

Screenshot from 2023-11-08 23-20-26

@mcserep
Copy link
Collaborator

mcserep commented Nov 10, 2023

It found a JS issue in the old web GUI though, which could be checked:
https://github.com/Ericsson/CodeCompass/security/code-scanning/1

(I am not sure what permission level on the project is required to access the page above.)
(As I see, only users with administrator privilege can see these reports by default, and further users needed to be added manually. I will review this finding later then.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Target: Developer environment Developer environment issues consist of CodeCompass or 3rd-party build tooling, configuration or CI.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants