Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix required checks in Probot Settings #42

Open
hassankhan opened this issue Nov 16, 2018 · 0 comments
Open

Fix required checks in Probot Settings #42

hassankhan opened this issue Nov 16, 2018 · 0 comments
Assignees
@sandyklark
Labels
bug Something isn't working

Comments

@hassankhan
Copy link
Contributor

hassankhan commented Nov 16, 2018 •
edited
Loading

Description

What went wrong?

The repo branch protection settings do not seem to work for Travis checks any more.

What did you expect should have happened?

Travis CI checks should be required before merging to develop and master.

Additional Data

This seems to be because the check name has changed from continuous-integration/travis-ci to Travis CI - Branch and Travis CI - Pull Request.

Version of generator-nodejs-ts you're using: v1.11.0

Node Version: 8.11

Operating System: macOS 10.13
@hassankhan hassankhan added the bug Something isn't working label Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandyklark sandyklark

Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hassankhan @sandyklark