Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

field rename #469

Open
neopaf opened this issue Apr 12, 2022 · 7 comments
Open

field rename #469

neopaf opened this issue Apr 12, 2022 · 7 comments
Assignees

Comments

@neopaf
Copy link

neopaf commented Apr 12, 2022

Environment(环境)

name version
IDEA version IDEA 2021.2.3
EmmyLua version 1.3.6.224-IDEA213
OS 10.15.7 (19H1824)

What are the steps to reproduce this issue?(重现步骤?)

---@class Test
---@field t1

---@type Test
local test = {}

local b = test.t2

What happens?(出现什么问题?)

t2 is not marked as invalid field:
Снимок экрана 2022-04-12 в 17 29 04

What were you expecting to happen?(期望?)

Line 7: t2 marked (by default in shade of red) as invalid field.

Any other comments?(其它说明)

Maybe optional...

@neopaf
Copy link
Author

neopaf commented Apr 12, 2022

using this opportunity let me deeply thank you for this extremely useful plugin!

@CppCXY CppCXY added the pending Pending review label Apr 12, 2022
@CppCXY CppCXY self-assigned this Apr 12, 2022
@CppCXY
Copy link
Member

CppCXY commented Apr 13, 2022

intellij emmylua does not currently support this check

@CppCXY CppCXY added enhancement and removed pending Pending review labels Apr 13, 2022
@neopaf
Copy link
Author

neopaf commented Apr 13, 2022

Is it something that can be quick-fixed? Looks like some one function to be provided and a simple one.

But then again, it so looks ;)

@CppCXY
Copy link
Member

CppCXY commented Apr 13, 2022

vscode emmylua support this, but it is still in the experimental stage

@CppCXY
Copy link
Member

CppCXY commented Apr 13, 2022

image

@neopaf
Copy link
Author

neopaf commented Apr 13, 2022

hm.. are you implying current version can do that?

When I tried to check, my Idea shows this:

Снимок экрана 2022-04-13 в 16 35 04

bbb is not marked at all :(

Maybe you're showing a quick preview at future happiness? :)

@CppCXY
Copy link
Member

CppCXY commented Apr 18, 2022

after next release,I would consider this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants