Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore restructuring status format since jobtype keys are on top-level of JSON #128

Open
Eo300 opened this issue Aug 3, 2021 · 1 comment
Assignees
Labels
core Required to build base system enhancement New feature or request

Comments

@Eo300
Copy link
Collaborator

Eo300 commented Aug 3, 2021

Top level of status JSON should have more generic keys, rather than any of them being jobtype-dependent

Current:

# file: 'pdb2pqr-status.json'
{
    "jobid": "sampleId",
    "jobtype": "pdb2pqr",
    "pdb2pqr": {
        "status": "pending",
        "startTime": <some float number>,
        "endTime": <some float number>,
        "subtasks": [ ],
        "inputFiles": [ ],
        "outputFiles": [ ]
    }
}

The value for jobtype is also one of the top-level keys.

Options:

  • Use a single status file, having a "jobs" top-level key containing an object with the individual job statuses
  • Continue with the separate job files, and instead rename the third key (pdb2pqr in this case) to something like "details"

Requires change to Electrostatics/apbs-web to support new structure

@Eo300 Eo300 added enhancement New feature or request core Required to build base system labels Aug 3, 2021
@Eo300 Eo300 self-assigned this Aug 3, 2021
@intendo
Copy link
Contributor

intendo commented Aug 5, 2021

The more I think about this, the more I think it is better to keep the files separate. If you combine the apbs and pdb2pqr status files, what would the jobtype become? This might lead to more problems than it solves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Required to build base system enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants