Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Add shadows from blocky lights #78

Open
Andrew-Sor opened this issue Oct 14, 2024 · 17 comments
Open

[Suggestion] Add shadows from blocky lights #78

Andrew-Sor opened this issue Oct 14, 2024 · 17 comments
Assignees
Labels
suggestion New feature or request

Comments

@Andrew-Sor
Copy link

Is your feature request related to a problem? Please describe.
It would be really cool to have shadows and colored light from block lights in these shaders. The rooms would look much better with them, but now they are very overexposed... And in general, this would also improve the overall atmosphere of the game

Describe the solution you'd like
Shadows and colored light from block light sources. Shadows with approximately the same settings as shadows from the sun and moon (their resolution, colored shadows, soft shadows, etc.)

Describe alternatives you've considered
I've seen a few shaders for Iris with shadows and lighting like this, but one of them worked on OptiFine too. It's Rethinking Voxels.

Additional context
image
image
image

@Andrew-Sor Andrew-Sor added the suggestion New feature or request label Oct 14, 2024
@Uninventiv
Copy link

Honestly main issue here is performance, SDV strives to be a lightweight shader that can run well on most devices, floodfill is viable for colored light from blocklight but having to use voxelisation for shadows is gonna severely tank performance

@Andrew-Sor
Copy link
Author

use voxelisation

Is this possible to achieve only using voxelisation?
Well, if this is difficult, then at least you can add colored lighting from block light sources (i.e. different light sources should shine with their own color)

@null511
Copy link
Contributor

null511 commented Oct 14, 2024

you need voxelization for floodfill too; for block-light shadows you need ray-tracing, which gets very expensive & complicated

@Andrew-Sor
Copy link
Author

for block-light shadows you need ray-tracing

I don't have a video card and those shaders work, but at 10 FPS... But in addition to these shadows on high settings there are still a lot of effects, and since there are a lot of settings in a language I don't know well, I didn't figure out where they are turned on and configured...

@null511
Copy link
Contributor

null511 commented Oct 14, 2024

if you're saying you don't have an "RTX" card, then that is irrelevant since optifine/iris shaders cannot use that hardware anyways. You do not need RTX hardware for ray-tracing, that's just a faster way to do it on more modern hardware/graphics API's

@Andrew-Sor
Copy link
Author

Andrew-Sor commented Oct 14, 2024

if you're saying you don't have an "RTX" card, then that is irrelevant since optifine/iris shaders cannot use that hardware anyways. You do not need RTX hardware for ray-tracing, that's just a faster way to do it on more modern hardware/graphics API's

🤯 And I didn't know...

Well, let's assume that shadows can be transferred to the future... But will it be possible to implement different colored light from block sources?

@Andrew-Sor
Copy link
Author

By the way, why then do I have no reflections if SSR is disabled in ray tracing settings?

@Uninventiv
Copy link

Author

Shadows from blocklights are probably never happening due to performance, Eldeston wants this shader to look really good while running really well, the use of voxel floodfill for colored lights tho is something he wants to work on when he can.

@Uninventiv
Copy link

By the way, why then do I have no reflections if SSR is disabled in ray tracing settings?
As for this I'm pretty sure sky reflections are just hard-coded, you can try disabling rough reflections as well if that's enabled

@Andrew-Sor
Copy link
Author

sky reflections are just hard-coded

By the way, yes. And because of this, we have to fold the sky when the light from it is less than 6. And in the windows we begin to see black or brown color...

you can try disabling rough reflections as well if that's enabled

Ok. I try it. But I don't think it will change anything...

@remixofc
Copy link

Maybe Eldeston or someone else will fork this shaderpack and add shadows from blocky lights to it?

@Andrew-Sor
Copy link
Author

Maybe Eldeston or someone else will fork this shaderpack and add shadows from blocky lights to it?

I would be glad myself, but if I knew how...

@Eldeston Eldeston self-assigned this Oct 16, 2024
@Andrew-Sor
Copy link
Author

I'm new to GitHub... Can someone explain what this means?...
image

@Eldeston
Copy link
Owner

It means I am taking interest in this post.

@Andrew-Sor
Copy link
Author

Thank you, now it's clear

@Andrew-Sor
Copy link
Author

Andrew-Sor commented Oct 17, 2024

you can try disabling rough reflections as well if that's enabled

image
They are disabled by default. And if I disable SSR, the reflections disappear too.

Maybe I should create a separate issue?...

@Eldeston
Copy link
Owner

Enable rough reflections. Perhaps it will make it look better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants