From 4f9fa0a03fe4fff1981cc405d0511eeb53c6b2d0 Mon Sep 17 00:00:00 2001
From: EdwinBetanc0urt <EdwinBetanc0urt@outlook.com>
Date: Wed, 28 Aug 2024 19:18:19 -0400
Subject: [PATCH] fix: Read only tab when table is view.

---
 .../DataTable/Components/ChangeRecord.vue     | 28 +++++++--------
 .../convenienceButtons/DeleteRecordButton.vue | 30 +++++++++-------
 .../convenienceButtons/NewRecordButton.vue    | 34 +++++++++++--------
 .../convenienceButtons/SaveRecordButton.vue   |  4 +++
 .../convenienceButtons/UndoChangeButton.vue   |  4 +++
 .../TabManager/convenienceButtons/index.vue   |  1 +
 .../ADempiere/dictionary/window/index.js      | 13 ++++++-
 7 files changed, 71 insertions(+), 43 deletions(-)

diff --git a/src/components/ADempiere/DataTable/Components/ChangeRecord.vue b/src/components/ADempiere/DataTable/Components/ChangeRecord.vue
index 0ce22d5051..6e1304de07 100644
--- a/src/components/ADempiere/DataTable/Components/ChangeRecord.vue
+++ b/src/components/ADempiere/DataTable/Components/ChangeRecord.vue
@@ -1,19 +1,19 @@
 <!--
- ADempiere-Vue (Frontend) for ADempiere ERP & CRM Smart Business Solution
- Copyright (C) 2018-Present E.R.P. Consultores y Asociados, C.A. www.erpya.com
- Contributor(s): Edwin Betancourt EdwinBetanc0urt@outlook.com
- This program is free software: you can redistribute it and/or modify
- it under the terms of the GNU General Public License as published by
- the Free Software Foundation, either version 3 of the License, or
- (at your option) any later version.
+  ADempiere-Vue (Frontend) for ADempiere ERP & CRM Smart Business Solution
+  Copyright (C) 2018-Present E.R.P. Consultores y Asociados, C.A. www.erpya.com
+  Contributor(s): Edwin Betancourt EdwinBetanc0urt@outlook.com https://github.com/EdwinBetanc0urt
+  This program is free software: you can redistribute it and/or modify
+  it under the terms of the GNU General Public License as published by
+  the Free Software Foundation, either version 3 of the License, or
+  (at your option) any later version.
 
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU General Public License for more details.
+  This program is distributed in the hope that it will be useful,
+  but WITHOUT ANY WARRANTY; without even the implied warranty of
+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+  GNU General Public License for more details.
 
- You should have received a copy of the GNU General Public License
- along with this program. If not, see <https:www.gnu.org/licenses/>.
+  You should have received a copy of the GNU General Public License
+  along with this program. If not, see <https:www.gnu.org/licenses/>.
 -->
 
 <template>
@@ -72,7 +72,7 @@ export default defineComponent({
     }
   },
 
-  setup(props, { root }) {
+  setup(props) {
     const recordUuid = computed(() => {
       return store.getters.getUuidOfContainer(props.containerUuid)
     })
diff --git a/src/components/ADempiere/TabManager/convenienceButtons/DeleteRecordButton.vue b/src/components/ADempiere/TabManager/convenienceButtons/DeleteRecordButton.vue
index dd149717e6..3b1721ccf2 100644
--- a/src/components/ADempiere/TabManager/convenienceButtons/DeleteRecordButton.vue
+++ b/src/components/ADempiere/TabManager/convenienceButtons/DeleteRecordButton.vue
@@ -1,19 +1,19 @@
 <!--
- ADempiere-Vue (Frontend) for ADempiere ERP & CRM Smart Business Solution
- Copyright (C) 2018-Present E.R.P. Consultores y Asociados, C.A. www.erpya.com
- Contributor(s): Edwin Betancourt EdwinBetanc0urt@outlook.com https://github.com/EdwinBetanc0urt
- This program is free software: you can redistribute it and/or modify
- it under the terms of the GNU General Public License as published by
- the Free Software Foundation, either version 3 of the License, or
- (at your option) any later version.
+  ADempiere-Vue (Frontend) for ADempiere ERP & CRM Smart Business Solution
+  Copyright (C) 2018-Present E.R.P. Consultores y Asociados, C.A. www.erpya.com
+  Contributor(s): Edwin Betancourt EdwinBetanc0urt@outlook.com https://github.com/EdwinBetanc0urt
+  This program is free software: you can redistribute it and/or modify
+  it under the terms of the GNU General Public License as published by
+  the Free Software Foundation, either version 3 of the License, or
+  (at your option) any later version.
 
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU General Public License for more details.
+  This program is distributed in the hope that it will be useful,
+  but WITHOUT ANY WARRANTY; without even the implied warranty of
+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+  GNU General Public License for more details.
 
- You should have received a copy of the GNU General Public License
- along with this program. If not, see <https:www.gnu.org/licenses/>.
+  You should have received a copy of the GNU General Public License
+  along with this program. If not, see <https:www.gnu.org/licenses/>.
 -->
 
 <template>
@@ -194,6 +194,10 @@ export default defineComponent({
     })
 
     const isDeleteRecord = computed(() => {
+      const { table } = tabAttributes.value
+      if (!isEmptyValue(table) && table.is_view) {
+        return false
+      }
       if (isExistsChanges.value) {
         return false
       }
diff --git a/src/components/ADempiere/TabManager/convenienceButtons/NewRecordButton.vue b/src/components/ADempiere/TabManager/convenienceButtons/NewRecordButton.vue
index 9fe5c595ee..feb0c6dfb8 100644
--- a/src/components/ADempiere/TabManager/convenienceButtons/NewRecordButton.vue
+++ b/src/components/ADempiere/TabManager/convenienceButtons/NewRecordButton.vue
@@ -1,19 +1,19 @@
 <!--
- ADempiere-Vue (Frontend) for ADempiere ERP & CRM Smart Business Solution
- Copyright (C) 2018-Present E.R.P. Consultores y Asociados, C.A. www.erpya.com
- Contributor(s): Edwin Betancourt EdwinBetanc0urt@outlook.com https://github.com/EdwinBetanc0urt
- This program is free software: you can redistribute it and/or modify
- it under the terms of the GNU General Public License as published by
- the Free Software Foundation, either version 3 of the License, or
- (at your option) any later version.
-
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU General Public License for more details.
-
- You should have received a copy of the GNU General Public License
- along with this program. If not, see <https:www.gnu.org/licenses/>.
+  ADempiere-Vue (Frontend) for ADempiere ERP & CRM Smart Business Solution
+  Copyright (C) 2018-Present E.R.P. Consultores y Asociados, C.A. www.erpya.com
+  Contributor(s): Edwin Betancourt EdwinBetanc0urt@outlook.com https://github.com/EdwinBetanc0urt
+  This program is free software: you can redistribute it and/or modify
+  it under the terms of the GNU General Public License as published by
+  the Free Software Foundation, either version 3 of the License, or
+  (at your option) any later version.
+
+  This program is distributed in the hope that it will be useful,
+  but WITHOUT ANY WARRANTY; without even the implied warranty of
+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+  GNU General Public License for more details.
+
+  You should have received a copy of the GNU General Public License
+  along with this program. If not, see <https:www.gnu.org/licenses/>.
 -->
 
 <template>
@@ -126,6 +126,10 @@ export default defineComponent({
     })
 
     const isCreateRecord = computed(() => {
+      const { table } = tabAttributes.value
+      if (!isEmptyValue(table) && table.is_view) {
+        return false
+      }
       if (isSecondaryParentTab.value) {
         return false
       }
diff --git a/src/components/ADempiere/TabManager/convenienceButtons/SaveRecordButton.vue b/src/components/ADempiere/TabManager/convenienceButtons/SaveRecordButton.vue
index 4350fd5ec2..90171318d4 100644
--- a/src/components/ADempiere/TabManager/convenienceButtons/SaveRecordButton.vue
+++ b/src/components/ADempiere/TabManager/convenienceButtons/SaveRecordButton.vue
@@ -103,6 +103,10 @@ export default defineComponent({
     })
 
     const isSaveRecord = computed(() => {
+      const { table } = tabAttributes.value
+      if (!isEmptyValue(table) && table.is_view) {
+        return false
+      }
       if (isEmptyValue(recordUuid.value) || recordUuid.value === 'create-new') {
         return true
       }
diff --git a/src/components/ADempiere/TabManager/convenienceButtons/UndoChangeButton.vue b/src/components/ADempiere/TabManager/convenienceButtons/UndoChangeButton.vue
index 3ba3c6dd85..e0a57c3d8b 100644
--- a/src/components/ADempiere/TabManager/convenienceButtons/UndoChangeButton.vue
+++ b/src/components/ADempiere/TabManager/convenienceButtons/UndoChangeButton.vue
@@ -79,6 +79,10 @@ export default defineComponent({
     })
 
     const isUndoChanges = computed(() => {
+      const { table } = tabAttributes.value
+      if (!isEmptyValue(table) && table.is_view) {
+        return false
+      }
       if (!isEmptyValue(recordUuid.value)) {
         return isExistsChanges.value
       }
diff --git a/src/components/ADempiere/TabManager/convenienceButtons/index.vue b/src/components/ADempiere/TabManager/convenienceButtons/index.vue
index fb91a2cfc9..6cf5adaadc 100644
--- a/src/components/ADempiere/TabManager/convenienceButtons/index.vue
+++ b/src/components/ADempiere/TabManager/convenienceButtons/index.vue
@@ -91,6 +91,7 @@ import RefreshRecordButton from '@/components/ADempiere/TabManager/convenienceBu
 import DeleteRecordButton from '@/components/ADempiere/TabManager/convenienceButtons/DeleteRecordButton.vue'
 import OptionsSecuence from '@/components/ADempiere/TabManager/convenienceButtons/OptionsSecuence.vue'
 import PrintProcess from '@/components/ADempiere/TabManager/convenienceButtons/PrintProcess.vue'
+
 export default defineComponent({
   name: 'ConvenienceButtons',
 
diff --git a/src/utils/ADempiere/dictionary/window/index.js b/src/utils/ADempiere/dictionary/window/index.js
index 562324044b..18f3acc864 100644
--- a/src/utils/ADempiere/dictionary/window/index.js
+++ b/src/utils/ADempiere/dictionary/window/index.js
@@ -92,7 +92,10 @@ export function isReadOnlyTab({ parentUuid, containerUuid }) {
   if (isEmptyValue(storeTab)) {
     return true
   }
-  const { is_read_only, read_only_logic } = storeTab
+  const { table, is_read_only, read_only_logic } = storeTab
+  if (!isEmptyValue(table) && table.is_view) {
+    return true
+  }
   // if tab is read only, all fields are read only
   if (is_read_only) {
     return true
@@ -206,6 +209,9 @@ export function evaluateDefaultFieldShowed({
   if (!isParentTab && (link_column_name === column_name || parent_column_name === column_name)) {
     return true
   }
+  if (['Record_ID'].includes(column_name)) {
+    return true
+  }
   if (is_document && [ORGANIZATION, WAREHOUSE].includes(column_name)) {
     return true
   }
@@ -547,6 +553,11 @@ export const undoChange = {
   name: language.t('actionMenu.undo'),
   type: 'undoModifyData',
   enabled: ({ parentUuid, containerUuid }) => {
+    const storedTab = store.getters.getStoredTab(parentUuid, containerUuid)
+    const { table } = storedTab
+    if (!isEmptyValue(table) && table.is_view) {
+      return false
+    }
     return isEmptyValue(
       store.getters.getUuidOfContainer(containerUuid)
     )