Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Response.raise_for_status()? #2

Open
JohnVinyard opened this issue Feb 22, 2019 · 1 comment
Open

Use Response.raise_for_status()? #2

JohnVinyard opened this issue Feb 22, 2019 · 1 comment

Comments

@JohnVinyard
Copy link
Collaborator

TxBillSearch/txbillsearch/txbillsearch.py

Line 123 in 7f4a70d

# TODO: BUG: Distributed Computing Fallacy #1: The network is reliable.

I agree that you probably should also be handling things like ConnectionError and TimeoutError here, and you might have other reasons for doing it the way you are, but just wanted to point to Response.raise_for_status as a possible alternative to checking the status code, just in case you weren't aware of it.
@EdVinyard
Copy link
Owner

Beautiful! I'll change that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JohnVinyard @EdVinyard