New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies, PyPI and all that #4

Open

KrisThielemans opened this issue Nov 5, 2024 · 0 comments

KrisThielemans commented Nov 5, 2024

It'd be nice to clean this up a bit more for easier install. Some suggestions:

add requirements.txt with only petsird==0.2 and trimesh
modify environment.yml to depend on trimesh and petsird-via-pip
remove PETSIRD submodule
move main.py to something like petsird_to_mesh.py (probably in main folder, not `python/'), and rename the project as well.

More advanced stuff:

Not sure of the .devcontainer is useful for a Python only project
We could even put this on PyPI via pyproject.toml and GitHub actions (as per https://github.com/ETSInitiative/PETSIRD/blob/main/.github/workflows/ci.yml and https://github.com/ETSInitiative/PETSIRD/blob/main/python/pyproject.toml)

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment