Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Eulerian dycore grids from our testing #1237

Open
ekluzek opened this issue Jan 25, 2025 · 2 comments · May be fixed by #1215
Open

Remove Eulerian dycore grids from our testing #1237

ekluzek opened this issue Jan 25, 2025 · 2 comments · May be fixed by #1215
Assignees
Labels
enhancement New feature or request

Comments

@ekluzek
Copy link

ekluzek commented Jan 25, 2025

What is the feature/what would you like to discuss?

As part of removing the Eulerian dycore (and even if the dycore isn't removed) I think we should remove the Eulerian grids from the testing or at least limit them to maybe one or two. These are the Eulerian tests in the testlist that I see now:

  <test compset="QPC4" grid="T42_T42_mg17" name="SCT_D_Ln7" testmods="cam/scm_prep">
  <test compset="QPC6" grid="T42_T42_mg17" name="SCT_D_Ln7" testmods="cam/scm_prep_c6">
  <test compset="QPSCAMC5" grid="T42_T42_mg17" name="SMS_D_Ln7" testmods="cam/scmarm">
  <test compset="FDABIP04" grid="T42_T42_mg17" name="ERC_D_Ln9" testmods="cam/outfrq3s_usecase">
  <test compset="FHS94" grid="T42_T42_mg17" name="ERC_D_Ln9" testmods="cam/outfrq3s_usecase">
  <test compset="QPC5" grid="T42_T42_mg17" name="SCT_D_Ln7" testmods="cam/scm_prep">
  <test compset="FDABIP04" grid="T42z30_T42_mg17" name="ERP_D_Ln9" testmods="cam/outfrq9s">
  <test compset="FHS94" grid="T42_T42_mg17" name="ERP_D_Ln9" testmods="cam/outfrq9s">
  <test compset="FSCAMARM97" grid="T42_T42" name="SMS_D_Ln9" testmods="cam/outfrq9s">
  <test compset="FSCAMMPACE" grid="T42_T42" name="SMS_D_Ln9" testmods="cam/outfrq9s">
(ctsm_pylib) erik/cesm3_0_alpha05c> grep T85 components/cam/cime_config/testdefs/testlist_cam.xml
  <test compset="FDABIP04" grid="T85z30_T85_mg17" name="ERP_D_Ln9" testmods="cam/outfrq9s">
  <test compset="FDABIP04" grid="T85z60_T85_mg17" name="ERP_D_Ln9" testmods="cam/outfrq9s">
  <test compset="FHS94" grid="T85z30_T85_mg17" name="ERP_D_Ln9" testmods="cam/outfrq9s">
  <test compset="FHS94" grid="T85z60_T85_mg17" name="ERP_D_Ln9" testmods="cam/outfrq9s">
(ctsm_pylib) erik/cesm3_0_alpha05c> grep T5 components/cam/cime_config/testdefs/testlist_cam.xml
  <test compset="QPC5" grid="T5_T5_mg37" name="TMC_D" testmods="cam/ghgrmp_e8">
  <test compset="QPC4" grid="T5_T5_mg37" name="ERC_D_Ln9" testmods="cam/outfrq3s_usecase">
  <test compset="QPC4" grid="T5_T5_mg37" name="ERI_D_Ln18" testmods="cam/co2rmp">

Since we need to move these grids to use the MOM t232 land/ocean mask if these grids are kept we'll need to add grids for them into ccs_config that use the t232 mask rather than the POP mask (see #1236). I suggest that we don't do that and just shift all of the above grids to FV or SE grids.

Is there anyone in particular you want to be part of this conversation?

@cacraigucar @nusbaume @peverwhee

Will this change (regression test) answers?

No

Will you be implementing this enhancement yourself?

Any CAM SE can do this

@ekluzek ekluzek added the enhancement New feature or request label Jan 25, 2025
@cacraigucar
Copy link
Collaborator

@ekluzek - We have PR #1215 opened which is removing the EUL dycore. I've not taken a look at the details you've listed. Perhaps you and/or @brian-eaton who has opened the PR can make sure this PR has the required changes you've mentioned

@brian-eaton
Copy link
Collaborator

The Eulerian tests are removed in #1215. I'll add that this issue is resolved by that PR.

@brian-eaton brian-eaton linked a pull request Jan 27, 2025 that will close this issue
@ekluzek ekluzek linked a pull request Jan 27, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To Do
Development

Successfully merging a pull request may close this issue.

3 participants