(ZHA) Fixed a bug preventing long pressing actions to be triggered.

[Ivarvdb]

Ikea e2002 button up / button down / left hold / right hold are now working properly

Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.

Sections marked as * are required and need to be filled in.

Proposed change*

resolves #619.

Checklist*

• I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
• I properly tested proposed changes on my system and confirm that they are working as expected.
• I formatted files with Prettier using the command npm run format before submitting my Pull Request.

[github-actions]

Hey @EPMatt, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

[azachar]

I used the fork of @Ivarvdb, and finally my brightness up/down is working as expected, thank you for your bugfix!

[EPMatt]

Thank you so much for your contribution @Ivarvdb! And thanks @azachar for testing. 🚀

I'm publishing your fix to the main branch.

[EPMatt]

Also, thanks everyone for your kind patience - life happens, and unfortunately I couldn't contribute at all to this project for a long time. Luckily, I'm hopefully now slowly getting back to be more active here.

Thank you all for your continuous support - can't believe we are getting close to 900 stars!

[danleongjy]

I was also looking into why double-press actions for Styrbars don't trigger correctly when I came across this pull request. Not sure whether this is a real issue or not (I may be misunderstanding the logic in the code), but why is the logic for checking for double presses using the condition trigger_action | string in states(helper_last_controller_event)? Earlier lines save the old state of the helper to variable last_controller_event, then update helper to the new trigger_action. So by the time it gets to the check for double press, the condition will check if the trigger_action equals itself?

Should the conditions instead be trigger_action | string == last_controller_event?

[EPMatt]

Hey @danleongjy,

thank you for spotting that. It's been a while since I inspected my old code, but I have to admit that looks suspicious to me as well. Is the double press functionality restored with the latest version of the IKEA E2001/E2002 controller blueprint?

[danleongjy]

Nope the behaviour has not been resolved with the latest version of the E2001/2002 blueprint. I'll write up a new issue with my findings. Thanks Matt.