From fc041a342e0a3edd9601489367265da7a3b1eee9 Mon Sep 17 00:00:00 2001 From: silvester-pari Date: Thu, 19 Dec 2024 12:43:03 +0100 Subject: [PATCH] fix!: align play button property with others (`disablePlay`-> `play`) --- elements/layercontrol/src/components/layer-datetime.js | 4 ++-- elements/layercontrol/src/enums/stories/index.js | 2 +- elements/layercontrol/stories/layercontrol.stories.js | 2 +- elements/timecontrol/src/enums/stories.js | 2 ++ elements/timecontrol/src/main.js | 6 +++--- .../{disabled-play-button.js => disabled-buttons.js} | 10 ++++++---- elements/timecontrol/stories/format.js | 7 +++++-- elements/timecontrol/stories/index.js | 2 +- elements/timecontrol/stories/no-map.js | 5 +++-- elements/timecontrol/stories/primary.js | 2 ++ .../timecontrol/stories/programmatic-time-selection.js | 4 ++++ elements/timecontrol/stories/slider.js | 4 ++++ elements/timecontrol/stories/timecontrol.stories.js | 4 ++-- 13 files changed, 36 insertions(+), 18 deletions(-) rename elements/timecontrol/stories/{disabled-play-button.js => disabled-buttons.js} (78%) diff --git a/elements/layercontrol/src/components/layer-datetime.js b/elements/layercontrol/src/components/layer-datetime.js index 8b859b2e4..94d963f19 100644 --- a/elements/layercontrol/src/components/layer-datetime.js +++ b/elements/layercontrol/src/components/layer-datetime.js @@ -39,7 +39,7 @@ export class EOxLayerControlLayerDatetime extends LitElement { * Layer config for eox-jsonform * * @type {{ - * disablePlay?: boolean; + * play?: boolean; * slider?: boolean; * navigation?: boolean; * currentStep: string|number; @@ -110,7 +110,7 @@ export class EOxLayerControlLayerDatetime extends LitElement { .layer=${undefined} .navigation=${this.layerDatetime.navigation ?? false} .slider=${this.layerDatetime.slider ?? false} - .disablePlay=${this.layerDatetime.disablePlay ?? false} + .play=${this.layerDatetime.play ?? false} .controlValues=${this.layerDatetime.controlValues} .controlProperty=${undefined} current-step=${this.layerDatetime.currentStep} diff --git a/elements/layercontrol/src/enums/stories/index.js b/elements/layercontrol/src/enums/stories/index.js index 6c5085a38..c615c05cd 100644 --- a/elements/layercontrol/src/enums/stories/index.js +++ b/elements/layercontrol/src/enums/stories/index.js @@ -445,7 +445,7 @@ export const STORIES_LAYER_VESSEL_DENSITY_CARGO = { range: ["#C3EBDC", "#0ADC00", "#FEF500", "#F29300", "#800303"], }, layerDatetime: { - disablePlay: true, + play: false, slider: true, currentStep: "2021-03-01", displayFormat: "DD.MM.YYYY", diff --git a/elements/layercontrol/stories/layercontrol.stories.js b/elements/layercontrol/stories/layercontrol.stories.js index 9f7472b63..a8e3a3862 100644 --- a/elements/layercontrol/stories/layercontrol.stories.js +++ b/elements/layercontrol/stories/layercontrol.stories.js @@ -70,7 +70,7 @@ export const LayerStylesConfig = LayerStylesConfigStory; /** * By adding "datetime" as tool, the time for a specific layer can be modified. * The `layerDatetime` property of the layer allows passing the following properties of eox-timecontrol: - * `disablePlay`: allows disabling the timecontrol play button. + * `play`: allows disabling the timecontrol play button. * `slider`: show/hide timecontrol slider. * `currentStep`: current datetime string. * `controlValues`: The list of available values. diff --git a/elements/timecontrol/src/enums/stories.js b/elements/timecontrol/src/enums/stories.js index f4dc0e674..c897a6206 100644 --- a/elements/timecontrol/src/enums/stories.js +++ b/elements/timecontrol/src/enums/stories.js @@ -21,6 +21,8 @@ export const DEFAULT_ARGS = { "2023-04-17", "2023-04-24", ], + navigation: true, + play: true, // map layers: [ { diff --git a/elements/timecontrol/src/main.js b/elements/timecontrol/src/main.js index 76fdea8e7..9aecaa96b 100644 --- a/elements/timecontrol/src/main.js +++ b/elements/timecontrol/src/main.js @@ -54,7 +54,7 @@ export class EOxTimeControl extends LitElement { /** * Hides the play button if set */ - disablePlay: { type: Boolean, attribute: "disable-play" }, + play: { type: Boolean, attribute: "play" }, /** * Date format string for displaying the current step @@ -82,7 +82,7 @@ export class EOxTimeControl extends LitElement { /** @type {boolean} */ this.unstyled = false; /** @type {boolean} */ - this.disablePlay = false; + this.play = false; /** @type {boolean} */ this.navigation = true; /** @type {boolean} */ @@ -337,7 +337,7 @@ export class EOxTimeControl extends LitElement { ` : nothing} - ${!this.disablePlay + ${this.play ? html`