We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi! Thanks for such a nice work with this software, I would like to suggest the incorporation of a model I'm trying to use to fit my data, the Transition Line Model, based on https://iopscience.iop.org/article/10.1149/1945-7111/ac49ce/meta, and https://doi.org/10.1016/j.jpowsour.2016.10.090
I have rewritten the TLMQ code, to adapt it to this model
` def TLM(p, f): """Transmission-line model as defined in Eq. 1 of [1]
Notes ----- .. math:: Z = \\sqrt{\\frac{R_{d}}{Z_{S}}} \\coth \\sqrt{R_{d}Z_{S}} [1] Julian Ascolani-Yael et al 2022 J. Electrochem. Soc https://iopscience.iop.org/article/10.1149/1945-7111/ac49ce/meta`_. """ omega = 2 * np.pi * np.array(f) Rd, Rs, Qs, gamma = p[0], p[1], p[2], p[3] Zs = (1/Rs) + (Qs * (1j * omega) ** gamma) Z = np.sqrt(Rd / Zs) / np.tanh(np.sqrt(Rd * Zs)) return Z`
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hi! Thanks for such a nice work with this software, I would like to suggest the incorporation of a model I'm trying to use to fit my data, the Transition Line Model, based on https://iopscience.iop.org/article/10.1149/1945-7111/ac49ce/meta, and https://doi.org/10.1016/j.jpowsour.2016.10.090
I have rewritten the TLMQ code, to adapt it to this model
`
def TLM(p, f):
"""Transmission-line model as defined in Eq. 1 of [1]
The text was updated successfully, but these errors were encountered: