-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the way how component color is defined and set #22
Comments
Ok, let's focus on this now. I think the approach for this should be:
Then we would have unified way how to work with colors + less code in modifiers file |
I am not sure which API you are choosing but if it is Then you should first try to design and extend |
I was thinking just about Bulma.button.a [
color.isDanger
] I am aware of that it could theoretically lead to setting colors for components which don't support it, but we cannot prevent it anyway (you can still mixup various helpers - they are just classes) and API would be way cleaner. |
I didn't think about this solution. It's the same way of thinking as for |
I think we have this finished as well. |
As agreed in #20, we should rethink how to work with colors.
One way would be having
button.color color.isDanger
, or just have long list of possible colors and using it directlycolor.isDanger
(which I like more right now). Should discuss further.The text was updated successfully, but these errors were encountered: