Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abort a running task from UI #184

Open
DropSnorz opened this issue Dec 30, 2022 · 1 comment
Open

Abort a running task from UI #184

DropSnorz opened this issue Dec 30, 2022 · 1 comment
Labels
Type: Feature New Feature

Comments

@DropSnorz
Copy link
Owner

The only way to abort a running or planned task is by closing the app.
It would be helpful to cancel/abort a task: Plugin Sync, Bundle Installation, etc...
@DropSnorz DropSnorz added the Type: Feature New Feature label Dec 30, 2022
@DropSnorz DropSnorz changed the title Cancel or Abort a running task Abort or cancel a running task Dec 30, 2022
@DropSnorz DropSnorz changed the title Abort or cancel a running task Abort a running task from UI Dec 30, 2022
@DropSnorz
Copy link
Owner Author

Implementing task cancellation on top of JavaFx Task will introduce some complexity on each task logic definition.

During task execution, frequent calls should be made to task.isCancelled() during execution (downloads, file move, ...) to handle the cancellation logic and complete the task gracefully. It means, we have to define all points in a task execution where cancellation is possible.

This cancellation won't help with a task stuck on a java or native call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DropSnorz