Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Round-robin creates BYEs without BYEs in the seeding #102

Closed
MrFastDie opened this issue Aug 21, 2021 · 2 comments
Closed

Round-robin creates BYEs without BYEs in the seeding #102

MrFastDie opened this issue Aug 21, 2021 · 2 comments
Assignees
@Drarig29

Comments

@MrFastDie
Copy link

When creating round robin with lets say 16 teams with names like Team 1, Team 2, ... it creates some BYE-Entries for me.
@Drarig29
Copy link
Owner

I removed "BYE vs. BYE" matches (#50) and I thought keeping "Team vs. BYE" was good, but you are right, it can be misleading.

I will remove them too I think.

Example:

image

@Drarig29 Drarig29 changed the title round_robin creates NULL values Round robin creates BYEs without BYEs in the seeding Aug 21, 2021
@Drarig29 Drarig29 changed the title Round robin creates BYEs without BYEs in the seeding Round-robin creates BYEs without BYEs in the seeding Aug 21, 2021
@Drarig29 Drarig29 self-assigned this Aug 22, 2021
@Drarig29
Copy link
Owner

This was because of groupCount being a string instead of a number.

In this line: https://github.com/MrFastDie/brackets-viewer.js/blob/0bd9446bf16a23410b600d423b538420f915b151/demo/index.html#L122

Related to #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Drarig29 Drarig29

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Drarig29 @MrFastDie