Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve enrichment process for rules, transactions, and graphs #44

Open
coderabbitai bot opened this issue Feb 2, 2025 · 0 comments
Open

Improve enrichment process for rules, transactions, and graphs #44

coderabbitai bot opened this issue Feb 2, 2025 · 0 comments

Comments

@coderabbitai
Copy link

coderabbitai bot commented Feb 2, 2025

Background

Currently, the enrichment process for various entities (rules, transactions, and graphs) lacks proper null checks and error handling when mapping related entities.

Areas Affected

  1. Rules enrichment

    • Label mapping in rules needs proper null checks
    • Error handling for missing labels needed
  2. Transactions enrichment

    • Similar issues may exist with related entity mappings
    • Need to review and improve error handling
  3. Graphs enrichment

    • Review and improve entity mapping process
    • Add proper null checks and error handling

References

Proposed Solution

Implement a consistent approach across all enrichment processes to:

  • Add proper null checks when mapping related entities
  • Include error logging for missing entities
  • Filter out null values from the final result
  • Consider adding validation at the data layer

Note: This improvement will help prevent runtime errors and provide better debugging information when related entities are missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants